Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro

Christoph Hellwig
2011-01-19T11:36:42Z

On Wed, Jan 19, 2011 at 08:46:10AM +1100, Dave Chinner wrote:
> > I would be nice to just move the quite flag into the normal mount flags
> > and have a xfs_mount_warn that checks it based off the mp.
>
> Given it is a flag that is only relevant for the mount context, is
> there really any need to use a flag that persists for the entire
> life of the filesystem for it? I don't think the code is that hard
> to follow right now. ;)

We can clear the flag after the mount. But in the end it's probably
not worth bothering, so feel free to leave it as-is.