public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 3/4] xfstests: make 016 work with delaylog
Date: Tue, 25 Jan 2011 14:58:56 +1100	[thread overview]
Message-ID: <1295927937-20634-4-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1295927937-20634-1-git-send-email-david@fromorbit.com>

From: Dave Chinner <dchinner@redhat.com>

Test 016 fails with delaylog because it measures log traffic to disk
and delaylog writes almost nothing to the log for the given test. TO
make it work, add sync calls to the work loop to cause the log to be
flushed reliably for both delaylog and nodelaylog and hence contain
the same nuumber of log records.

As a result, the log space consumed by the test is not changed by
the delaylog option and the test passes. The test is not
significantly slowed down by the addition of the sync calls (takes
15s to run on a single SATA drive).

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 016 |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/016 b/016
index 980eb0b..32d8b19 100755
--- a/016
+++ b/016
@@ -101,7 +101,9 @@ _log_traffic()
     while [ $count -ge 0 ]
     do
         touch $out
+	sync
         rm $out
+	sync
         let "count = count - 1"
     done
 
-- 
1.7.2.3

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2011-01-25  3:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25  3:58 [PATCH 0/4] xfstests: new tests and fixes Dave Chinner
2011-01-25  3:58 ` [PATCH 1/4] xfstests: add simple splice test Dave Chinner
2011-01-26 20:33   ` Christoph Hellwig
2011-02-02  1:28   ` Alex Elder
2011-01-25  3:58 ` [PATCH 2/4] xfstests: add test to reproduce bmap btree corruption Dave Chinner
2011-01-26 20:33   ` Christoph Hellwig
2011-02-02  1:29   ` Alex Elder
2011-02-02  2:17     ` Dave Chinner
2011-01-25  3:58 ` Dave Chinner [this message]
2011-01-26 20:34   ` [PATCH 3/4] xfstests: make 016 work with delaylog Christoph Hellwig
2011-02-02  1:30   ` Alex Elder
2011-01-25  3:58 ` [PATCH 4/4] xfstests: Speed up test 042 Dave Chinner
2011-01-26 20:35   ` Christoph Hellwig
2011-02-02  1:30   ` Alex Elder
2011-02-02  2:12     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295927937-20634-4-git-send-email-david@fromorbit.com \
    --to=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox