Re: [PATCH 4/4] xfstests: Speed up test 042

Christoph Hellwig
2011-01-26T20:33:24Z

On Tue, Jan 25, 2011 at 02:58:57PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> test 042 generates a worst-case fragmented filesystem and uses it to
> test xfs_fsr. It uses small 4k files to generate the hole-space-hole
> pattern that fragments free space badly. It is much faster to
> generate the same pattern by creating a single large file and
> punching holes in it. Also, instead of writing large files to
> create unfragmented space, just use preallocation so we don't have
> to write the data to disk.
>
> These changes reduce the runtime of the test on a single SATA drive
> from 106s to 27s.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>