From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Josef Bacik <josef@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] Xfstests: make 014 only run on xfs
Date: Tue, 01 Feb 2011 17:48:57 -0600 [thread overview]
Message-ID: <1296604137.2350.138.camel@doink> (raw)
In-Reply-To: <20110127005945.GE21311@dastard>
On Thu, 2011-01-27 at 11:59 +1100, Dave Chinner wrote:
> On Wed, Jan 26, 2011 at 09:05:29AM -0500, Josef Bacik wrote:
> > This test relies on mounting with -o allocsize, which is an xfs specific mount
> > option, so make the test only work on xfs. Thanks,
>
> Oh, sorry, my fault. Perhaps something like this instead?
Since test 014 reportedly works on other filesystem
types provided the allocsize option isn't provided,
Dave's version looks better.
Josef will you please take a look over--and preferably
test--what Dave proposed, and if you agree offer your
signoff?
Thanks.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-02-01 23:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 14:05 [PATCH] Xfstests: make 014 only run on xfs Josef Bacik
2011-01-26 16:56 ` Christoph Hellwig
2011-01-27 0:59 ` Dave Chinner
2011-02-01 23:48 ` Alex Elder [this message]
2011-02-02 0:58 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296604137.2350.138.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=josef@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox