From: Alex Elder <aelder@sgi.com>
To: Ajeet Yadav <ajeet.yadav.77@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: mkfs.xfs pagefault when removed storage during operation
Date: Mon, 07 Feb 2011 19:35:31 -0600 [thread overview]
Message-ID: <1297128931.2078.32.camel@doink> (raw)
In-Reply-To: <AANLkTi=7dw1-r8BSdv7y51LzmWekxKjLrCv_Rky7EYx9@mail.gmail.com>
On Wed, 2011-02-02 at 17:09 +0900, Ajeet Yadav wrote:
> If I see the current sigfault, its easy to fix adding one more patch
> to xfsprogs.
. . .
>
> But when I start reviewing the complete project w.r.t read() /
> read64() / write() / write64() more importantly libxfs_readbufr() /
> libxfs_writebufr().
> I find error handing is broken at may places and I get my self lost in
> m^n complexity also errno is lost.. therefore caller cannot examine
> the exact error,
>
> Back again I think, What if I exit on error ? Does xfsprogs uses
> read() / write() error as a part of its functionality, for example
> does xfs_repair uses these errors as a part of repair funtionality.
. . .
I think these are good observations and questions.
This doesn't answer your questions, but I want to mention to
you that libxfs is just about to have a major update that
affects lots of files. I expect the update will *not*
address the issues you point out here, but I guess what I'd
like to do is get us moved to the updated code before trying
to address problems that might be widespread like this.
I hope to complete this update process soon, but I expect
it will be a week or more before that happens.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-02-08 1:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 11:06 mkfs.xfs pagefault when removed storage during operation Ajeet Yadav
2011-02-02 8:09 ` Ajeet Yadav
2011-02-08 1:35 ` Alex Elder [this message]
2011-02-08 2:27 ` Ajeet Yadav
2011-02-03 4:10 ` Eric Sandeen
2011-02-03 6:03 ` Ajeet Yadav
2011-02-03 6:07 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297128931.2078.32.camel@doink \
--to=aelder@sgi.com \
--cc=ajeet.yadav.77@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox