From: Alex Elder <aelder@sgi.com>
To: xfs@oss.sgi.com
Cc: Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH] xfs_repair: validate inode di_flaaags field
Date: Tue, 22 Feb 2011 15:39:05 -0600 [thread overview]
Message-ID: <1298410745.1960.73.camel@doink> (raw)
In-Reply-To: <1298407556.1960.54.camel@doink>
On Tue, 2011-02-22 at 14:45 -0600, Alex Elder wrote:
> On Tue, 2011-02-22 at 14:43 -0600, Alex Elder wrote:
> > (I may have missed it, but I don't believe Dave posted
> > this patch so I'm doing it for him to get it on the
> > list. -Alex)
> >
> > xfs-reapir is not validating the di_flags field in the inode for
> > sanity. Block fuzzing indicates that we are not picking situations
> > like the RT bit being set on filesystems without realtime devices.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
Turns out this was on the list, it just was sent as a
"will you please try this patch" message on the subject
of "XFS internal error xfs_iformat(realtime) even after
xfs_repair."
Anyway, now I've reviewed it, and it looks good. The
typo's in the subject line and in the description ought
to be fixed before it's committed.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-02-22 21:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 20:43 [PATCH] xfs_repair: validate inode di_flaaags field Alex Elder
2011-02-22 20:45 ` Alex Elder
2011-02-22 21:39 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298410745.1960.73.camel@doink \
--to=aelder@sgi.com \
--cc=dchinner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox