From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Cc: aelder@sgi.com
Subject: [PATCH] xfs_repair: inode flags check should use flags
Date: Thu, 24 Feb 2011 09:29:11 +1100 [thread overview]
Message-ID: <1298500151-27017-1-git-send-email-david@fromorbit.com> (raw)
From: Dave Chinner <dchinner@redhat.com>
The RT bitmap inode format flag check should use the flag, not the
bit definition. As a result, it is incorrectly detecting inodes with
the prealloc flag set as has having an invalid bit set.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
---
repair/dinode.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/repair/dinode.c b/repair/dinode.c
index fad15b2..3a092e4 100644
--- a/repair/dinode.c
+++ b/repair/dinode.c
@@ -2551,11 +2551,11 @@ process_dinode_int(xfs_mount_t *mp,
XFS_DIFLAG_RTINHERIT);
}
}
- if (flags & XFS_DIFLAG_NEWRTBM_BIT) {
+ if (flags & XFS_DIFLAG_NEWRTBM) {
/* must be a rt bitmap inode */
if (lino != mp->m_sb.sb_rbmino) {
do_warn(_("inode %llu not rt bitmap"), lino);
- flags &= ~XFS_DIFLAG_NEWRTBM_BIT;
+ flags &= ~XFS_DIFLAG_NEWRTBM;
}
}
if (flags & (XFS_DIFLAG_RTINHERIT |
--
1.7.2.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2011-02-23 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 22:29 Dave Chinner [this message]
2011-02-23 22:31 ` [PATCH] xfs_repair: inode flags check should use flags Alex Elder
2011-02-23 23:45 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298500151-27017-1-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox