From: Alex Elder <aelder@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>,
xfs@oss.sgi.com,
Josef Bacik <jbacik@redhat.com>mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/2 V2] xfstests 225: add additional fiemap-tester run without sync
Date: Fri, 25 Feb 2011 14:47:55 -0600 [thread overview]
Message-ID: <1298666875.1990.7114.camel@doink> (raw)
In-Reply-To: <4D66D8F2.10501@sandeen.net>
On Thu, 2011-02-24 at 16:17 -0600, Eric Sandeen wrote:
> Chris Mason pointed out that some filesystems were not doing
> the right thing on fiemap, in the face of delalloc extents.
>
> Because test 225 ran with FIEMAP_FLAG_SYNC only, this didn't
> get caught. Add a runtime option, and run it both ways.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good. Please add a line to document the option
in the usage() function as suggested by Josef before
committing.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-02-25 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 22:04 [PATCH 2/2] xfstests 225: add additional fiemap-tester run without sync Eric Sandeen
2011-02-24 22:17 ` [PATCH 2/2 V2] " Eric Sandeen
2011-02-25 14:49 ` Josef Bacik
2011-02-25 20:47 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298666875.1990.7114.camel@doink \
--to=aelder@sgi.com \
--cc=jbacik@redhat.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox