From: Alex Elder <aelder@sgi.com>
To: Boris Ranto <branto@redhat.com>
Cc: xfs <xfs@oss.sgi.com>
Subject: Re: xfstests: change directory to / before _cleanup_testdir in test 135
Date: Mon, 07 Mar 2011 14:12:29 -0600 [thread overview]
Message-ID: <1299528749.2578.821.camel@doink> (raw)
In-Reply-To: <1299511558.3183.115.camel@dhcp-31-190.brq.redhat.com>
On Mon, 2011-03-07 at 16:25 +0100, Boris Ranto wrote:
> Nfs tries to umount $testdir in _cleanup_testdir function. The test 135 calls the function from directory $SCRATCH_MNT that is equal to $testdir (at least for nfs). The umount will therefore fail causing the test to fail due to the output mismatch.
>
> This simple patch fixes the issue for me.
>
> Signed-off-by: Boris Ranto <branto@redhat.com>
This looks OK to me. Most other tests do this chdir
in their cleanup function.
I did a quick scan and found that test 126 may suffer the
same problem. Can you check this? We could include the
fix for both tests in the same commit.
It also looks to me like tests 069, 089 might have a
similar issue if they get interrupted.
-Alex
> diff -urpN a/xfstests/135 b/xfstests/135
> --- a/xfstests/135 2011-03-07 14:54:15.855172101 +0100
> +++ b/xfstests/135 2011-03-07 14:54:29.895048375 +0100
> @@ -34,6 +34,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 1
>
> _cleanup()
> {
> + cd /
> _cleanup_testdir
> }
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-07 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 15:25 xfstests: change directory to / before _cleanup_testdir in test 135 Boris Ranto
2011-03-07 20:12 ` Alex Elder [this message]
2011-03-08 13:29 ` Boris Ranto
2011-03-08 20:14 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299528749.2578.821.camel@doink \
--to=aelder@sgi.com \
--cc=branto@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox