public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfstests 225: Run with different random seeds
@ 2011-03-08 15:39 Eric Sandeen
  2011-03-08 20:10 ` Alex Elder
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2011-03-08 15:39 UTC (permalink / raw)
  To: xfs-oss; +Cc: Chris Mason

Running the fiemap-tester with a unique random seed each time
may uncover some things missed by always using the default.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/225 b/225
index 2dea3c2..76be888 100755
--- a/225
+++ b/225
@@ -60,11 +60,15 @@ _cleanup()
 }
 trap "_cleanup; exit \$status" 0 1 2 3 15
 
+seed=`date +%s`
+
+echo "using seed $seed" >> $fiemaplog
+
 echo "fiemap run without preallocation, with sync"
-$here/src/fiemap-tester -q -S -p 0 -r 200 $fiemapfile 2>&1 | tee $fiemaplog
+$here/src/fiemap-tester -q -S -s $seed -p 0 -r 200 $fiemapfile 2>&1 | tee -a $fiemaplog
 
 echo "fiemap run without preallocation or sync"
-$here/src/fiemap-tester -q -p 0 -r 200 $fiemapfile 2>&1 | tee $fiemaplog
+$here/src/fiemap-tester -q -s $seed -p 0 -r 200 $fiemapfile 2>&1 | tee -a $fiemaplog
 
 if grep -q "Operation not supported" $fiemaplog; then
       _notrun "FIEMAP not supported by this filesystem type: $FSTYP"

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] xfstests 225: Run with different random seeds
  2011-03-08 15:39 [PATCH] xfstests 225: Run with different random seeds Eric Sandeen
@ 2011-03-08 20:10 ` Alex Elder
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2011-03-08 20:10 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: Chris Mason, xfs-oss

On Tue, 2011-03-08 at 09:39 -0600, Eric Sandeen wrote:
> Running the fiemap-tester with a unique random seed each time
> may uncover some things missed by always using the default.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>



_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-08 20:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-08 15:39 [PATCH] xfstests 225: Run with different random seeds Eric Sandeen
2011-03-08 20:10 ` Alex Elder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox