From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfstests: a few fixes to Makefile
Date: Thu, 10 Mar 2011 16:16:06 -0600 [thread overview]
Message-ID: <1299795366.2573.78.camel@doink> (raw)
In-Reply-To: <20110310172537.GB13390@infradead.org>
On Thu, 2011-03-10 at 12:25 -0500, Christoph Hellwig wrote:
> > +ifeq ($(HAVE_DMAPI), true)
> > # automake doesn't always support "default" target
> > # so do dmapi make explicitly with "all"
> > -ifeq ($(HAVE_DMAPI), true)
>
> What about moving the # signs to the first line so that it never gets
> echoed at all?
>
> Otherwise looks good to me.
That would work too. A later patch makes the
whole thing go away though, so it's sort of moot.
(And I already committed it after some discussion
with Eric yesterday...)
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-10 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 19:37 [PATCH 1/2] xfstests: a few fixes to Makefile Alex Elder
2011-03-10 17:25 ` Christoph Hellwig
2011-03-10 22:16 ` Alex Elder [this message]
2011-03-11 10:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299795366.2573.78.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox