From: Alex Elder <aelder@sgi.com>
To: XFS Mailing List <xfs@oss.sgi.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH] xfs: don't name variables "panic"
Date: Fri, 11 Mar 2011 06:39:51 -0600 [thread overview]
Message-ID: <1299847191.3462.1.camel@doink> (raw)
In-Reply-To: <AANLkTi=Hg4s5kEMQZu_KGePf4W_7jAFm0_WifM9W3PR6@mail.gmail.com>
The new xfs_alert_tag() used a variable named "panic",
and that is to be avoided. Rename it.
Signed-off-by: Alex Elder <aelder@sgi.com>
---
fs/xfs/linux-2.6/xfs_message.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: b/fs/xfs/linux-2.6/xfs_message.c
===================================================================
--- a/fs/xfs/linux-2.6/xfs_message.c
+++ b/fs/xfs/linux-2.6/xfs_message.c
@@ -96,13 +96,13 @@ xfs_alert_tag(
{
struct va_format vaf;
va_list args;
- int panic = 0;
+ int do_panic = 0;
int r;
if (xfs_panic_mask && (xfs_panic_mask & panic_tag)) {
xfs_printk(KERN_ALERT, mp,
"XFS: Transforming an alert into a BUG.");
- panic = 1;
+ do_panic = 1;
}
va_start(args, fmt);
@@ -113,7 +113,7 @@ xfs_alert_tag(
r = __xfs_printk(KERN_ALERT, mp, &vaf);
va_end(args);
- BUG_ON(panic);
+ BUG_ON(do_panic);
return r;
}
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-11 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 12:21 [next] xfs: error: called object 'panic' is not a function Geert Uytterhoeven
2011-03-11 12:39 ` Alex Elder [this message]
2011-03-13 0:49 ` [PATCH] xfs: don't name variables "panic" Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299847191.3462.1.camel@doink \
--to=aelder@sgi.com \
--cc=geert@linux-m68k.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox