[next] xfs: error: called object 'panic' is not a function

[next] xfs: error: called object 'panic' is not a function

[Geert Uytterhoeven]

http://kisskb.ellerman.id.au/kisskb/buildresult/3977742/:

| fs/xfs/linux-2.6/xfs_message.c:116: error: called object 'panic' is
not a function
| make[3]: *** [fs/xfs/linux-2.6/xfs_message.o] Error 1

Lemme guess, the problem fixed by commit
cf78859f520f8275318f47d7864f4459d940cb6b (xfs: Do not name variables "panic")
has reincarnated somewhere else?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH] xfs: don't name variables "panic"

[Alex Elder]

The new xfs_alert_tag() used a variable named "panic",
and that is to be avoided.  Rename it.

Signed-off-by: Alex Elder <aelder@sgi.com>

---
 fs/xfs/linux-2.6/xfs_message.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: b/fs/xfs/linux-2.6/xfs_message.c
===================================================================
--- a/fs/xfs/linux-2.6/xfs_message.c
+++ b/fs/xfs/linux-2.6/xfs_message.c
@@ -96,13 +96,13 @@ xfs_alert_tag(
 {
        struct va_format        vaf;
        va_list                 args;
-       int                     panic = 0;
+       int                     do_panic = 0;
        int                      r;

        if (xfs_panic_mask && (xfs_panic_mask & panic_tag)) {
                xfs_printk(KERN_ALERT, mp,
                        "XFS: Transforming an alert into a BUG.");
-               panic = 1;
+               do_panic = 1;
        }

        va_start(args, fmt);
@@ -113,7 +113,7 @@ xfs_alert_tag(
        r = __xfs_printk(KERN_ALERT, mp, &vaf);
        va_end(args);

-       BUG_ON(panic);
+       BUG_ON(do_panic);

        return r;
 }


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs: don't name variables "panic"

[Dave Chinner]

On Fri, Mar 11, 2011 at 06:39:51AM -0600, Alex Elder wrote:
> The new xfs_alert_tag() used a variable named "panic",
> and that is to be avoided.  Rename it.
> 
> Signed-off-by: Alex Elder <aelder@sgi.com>

My fault. Fix looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

Cheers,

Dave
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs