From: Alex Elder <aelder@sgi.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: ensure selinux xattrs don't interfere with quota tests
Date: Tue, 22 Mar 2011 14:30:07 -0500 [thread overview]
Message-ID: <1300822207.2875.23.camel@doink> (raw)
In-Reply-To: <4D83B2D0.1030607@redhat.com>
On Fri, 2011-03-18 at 14:30 -0500, Eric Sandeen wrote:
> 219 and 235 were failing on ext3 with selinux, because the extra
> xattrs upped the quota usage.
>
> Do the same trick we've used in the past to mount with an selinux
> global context when doing quota tests.
>
> Note the gross hack for remount,ro, though.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
My only suggestion would be to define the value of
the security context using a variable, so it's
easier to see that the thing you're editing out of
/etc/mtab is identical to the thing that was
supplied as a mount option. I.e., define
MOUNT_CONTEXT="system_u:object_r:nfs_t:s0"
and use it in the two spots elsewhere.
But even if you don't take that suggestion this
looks good to me.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-03-22 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 19:30 [PATCH] xfstests: ensure selinux xattrs don't interfere with quota tests Eric Sandeen
2011-03-22 10:01 ` Christoph Hellwig
2011-03-22 19:30 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300822207.2875.23.camel@doink \
--to=aelder@sgi.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox