From: Alex Elder <aelder@sgi.com>
To: David Sterba <dsterba@suse.cz>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: cleanup duplicate initializations
Date: Mon, 28 Mar 2011 13:52:50 -0500 [thread overview]
Message-ID: <1301338370.2622.10.camel@doink> (raw)
In-Reply-To: <1301332373-24914-1-git-send-email-dsterba@suse.cz>
On Mon, 2011-03-28 at 19:12 +0200, David Sterba wrote:
> follow these guidelines:
> - leave initialization in the declaration block if it fits the line
> - move to the code where it's more suitable ('for' init block)
>
> Signed-off-by: David Sterba <dsterba@suse.cz>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-28 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 17:12 [PATCH] xfs: cleanup duplicate initializations David Sterba
2011-03-28 18:52 ` Alex Elder [this message]
2011-04-13 22:03 ` [PATCH, v2] " Alex Elder
2011-04-13 22:53 ` Dave Chinner
2011-04-14 14:50 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301338370.2622.10.camel@doink \
--to=aelder@sgi.com \
--cc=dsterba@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox