From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/5] xfs: do not immediately reuse busy extent ranges
Date: Tue, 29 Mar 2011 14:04:16 -0500 [thread overview]
Message-ID: <1301425456.3026.244.camel@doink> (raw)
In-Reply-To: <20110328210914.791205854@bombadil.infradead.org>
On Mon, 2011-03-28 at 17:06 -0400, Christoph Hellwig wrote:
> Every time we reallocate a busy extent, we cause a synchronous log force
> to occur to ensure the freeing transaction is on disk before we continue
> and use the newly allocated extent. This is extremely sub-optimal as we
> have to mark every transaction with blocks that get reused as synchronous.
>
> Instead of searching the busy extent list after deciding on the extent to
> allocate, check each candidate extent during the allocation decisions as
> to whether they are in the busy list. If they are in the busy list, we
> trim the busy range out of the extent we have found and determine if that
> trimmed range is still OK for allocation. In many cases, this check can
> be incorporated into the allocation extent alignment code which already
> does trimming of the found extent before determining if it is a valid
> candidate for allocation.
>
> Based on two earlier patches from Dave Chinner.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-29 19:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 21:06 [PATCH 0/5] improved busy extent handling Christoph Hellwig
2011-03-28 21:06 ` [PATCH 1/5] xfs: optimize AGFL refills Christoph Hellwig
2011-03-29 19:04 ` Alex Elder
2011-03-28 21:06 ` [PATCH 2/5] xfs: do not immediately reuse busy extent ranges Christoph Hellwig
2011-03-29 19:04 ` Alex Elder [this message]
2011-03-28 21:06 ` [PATCH 3/5] xfs: exact busy extent tracking Christoph Hellwig
2011-03-29 19:04 ` Alex Elder
2011-03-28 21:06 ` [PATCH 4/5] xfs: allow reusing busy extents where safe Christoph Hellwig
2011-03-29 19:04 ` Alex Elder
2011-03-31 8:30 ` Christoph Hellwig
2011-03-28 21:06 ` [PATCH 5/5] xfs: update busy extent tracing Christoph Hellwig
2011-03-29 19:04 ` Alex Elder
2011-03-29 19:04 ` [PATCH 0/5] improved busy extent handling Alex Elder
2011-03-30 10:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301425456.3026.244.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox