Re: [PATCH 3/5] xfs: exact busy extent tracking

Alex Elder
2011-03-29T19:01:25Z

On Mon, 2011-03-28 at 17:06 -0400, Christoph Hellwig wrote:
> Update the extent tree in case we have to reuse a busy extent, so that it
> always is kept uptodate. This is done by replacing the busy list searches
> with a new xfs_alloc_busy_reuse helper, which updates the busy extent tree
> in case of a reuse. Also replace setting transactions to sync with forcing
> the log out in case we found a busy extent to reuse. This makes the code a
> lot more simple, and is required for discard support later on. While it
> will cause performance regressios with just this patch applied, the impact
> is more than mitigated by the next patch in the series.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good. xfs_alloc_busy_update_extent() is a better name
than xfs_alloc_buisy_try_reuse() was.

Reviewed-by: Alex Elder <aelder@sgi.com>