From: Alex Elder <aelder@sgi.com>
To: xfs@oss.sgi.com
Subject: xfsprogs: avoid dot-directories when configuring
Date: Wed, 30 Mar 2011 12:52:39 -0500 [thread overview]
Message-ID: <1301507559.2953.12.camel@doink> (raw)
The "find" command used in the configure script to find localized
files searches through directories (including .git and .pc) that
really should be ignored. Change it so it skips over these
directories.
I think it's reasonable to assume any such "dot directory" should be
ignored, so this change skips any directory at the top level whose
name begins with ".".
Note that I found an odd anomaly in "find". If you do not supply
the "-print" argument, the pruned directory names show up in the
output. Supplying "-print" does not include them (and that's what
we want).
Signed-off-by: Alex Elder <aelder@sgi.com>
---
configure.in | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
Index: b/configure.in
===================================================================
--- a/configure.in
+++ b/configure.in
@@ -76,9 +76,12 @@ esac
AC_SUBST([root_sbindir])
AC_SUBST([root_libdir])
-# Find localized files
+# Find localized files. Don't descend into any "dot directories"
+# (like .git or .pc from quilt). Strangely, the "-print" argument
+# to "find" is required, to avoid including such directories in the
+# list.
LOCALIZED_FILES=""
-for lfile in `find ${srcdir} -name '*.c' -type f || exit 1`; do
+for lfile in `find ${srcdir} -path './.??*' -prune -o -name '*.c' -type f -print || exit 1`; do
LOCALIZED_FILES="$LOCALIZED_FILES \$(TOPDIR)/$lfile"
done
AC_SUBST(LOCALIZED_FILES)
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2011-03-30 17:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 17:52 Alex Elder [this message]
2011-03-30 18:46 ` xfsprogs: avoid dot-directories when configuring Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301507559.2953.12.camel@doink \
--to=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox