From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix variable set but not used warnings
Date: Mon, 04 Apr 2011 13:21:20 -0500 [thread overview]
Message-ID: <1301941280.2630.61.camel@doink> (raw)
In-Reply-To: <20110404125544.GA726@infradead.org>
On Mon, 2011-04-04 at 08:55 -0400, Christoph Hellwig wrote:
> GCC 4.6 now warnings about variables set but not used. Fix the trivially
> fixable warnings of this sort.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good. I have an unrelated question though.
Reviewed-by: Alex Elder <aelder@sgi.com>
> Index: linux-2.6/fs/xfs/quota/xfs_qm_syscalls.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/quota/xfs_qm_syscalls.c 2011-04-03 06:40:45.399789765 -0700
> +++ linux-2.6/fs/xfs/quota/xfs_qm_syscalls.c 2011-04-03 06:43:00.219782939 -0700
> @@ -313,14 +313,12 @@ xfs_qm_scall_quotaon(
> {
> int error;
> uint qf;
> - uint accflags;
> __int64_t sbflags;
>
> flags &= (XFS_ALL_QUOTA_ACCT | XFS_ALL_QUOTA_ENFD);
> /*
> * Switching on quota accounting must be done at mount time.
> */
> - accflags = flags & XFS_ALL_QUOTA_ACCT;
> flags &= ~(XFS_ALL_QUOTA_ACCT);
Unrelated, but isn't the effect of this line plus the one a few
lines up the same as this?
flags &= XFS_ALL_QUOTA_ENFD;
>
> sbflags = 0;
. . .
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-04-04 18:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 12:55 [PATCH] xfs: fix variable set but not used warnings Christoph Hellwig
2011-04-04 18:21 ` Alex Elder [this message]
2011-04-04 23:52 ` David Sterba
2011-04-05 6:05 ` Dave Chinner
2011-04-07 13:45 ` David Sterba
2011-04-05 19:10 ` Christoph Hellwig
2011-04-05 0:10 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301941280.2630.61.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox