Re: [PATCH 4/9] xfs: introduce background inode reclaim work

Christoph Hellwig
2011-04-06T18:11:10Z

> + * We can have inodes enter reclaim after we've shut down the syncd workqueue
> + * during unmount, so don't allow reclaim work to be queued during unmount.

Nipick: this part of the comment would be better just above the
MS_ACTIVE check. I just tried to figure out what it was for, and it
took me a while to realize the explanation was in the block comment
above the function.

> +static void
> +xfs_syncd_queue_reclaim(
> + struct xfs_mount *mp)
> +{
> + if (!(mp->m_super->s_flags & MS_ACTIVE))
> + return;

Otherwise looks good.