From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/9] xfs: convert ENOSPC inode flushing to use new syncd workqueue
Date: Thu, 07 Apr 2011 16:16:11 -0500 [thread overview]
Message-ID: <1302210971.2576.599.camel@doink> (raw)
In-Reply-To: <1302141445-27457-4-git-send-email-david@fromorbit.com>
On Thu, 2011-04-07 at 11:57 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> On of the problems with the current inode flush at ENOSPC is that we
> queue a flush per ENOSPC event, regardless of how many are already
> queued. Thi can result in hundreds of queued flushes, most of
> which simply burn CPU scanned and do no real work. This simply slows
> down allocation at ENOSPC.
>
> We really only need one active flush at a time, and we can easily
> implement that via the new xfs_syncd_wq. All we need to do is queue
> a flush if one is not already active, then block waiting for the
> currently active flush to complete. The result is that we only ever
> have a single ENOSPC inode flush active at a time and this greatly
> reduces the overhead of ENOSPC processing.
>
> On my 2p test machine, this results in tests exercising ENOSPC
> conditions running significantly faster - 042 halves execution time,
> 083 drops from 60s to 5s, etc - while not introducing test
> regressions.
>
> This allows us to remove the old xfssyncd threads and infrastructure
> as they are no longer used.
Looks good. You got rid of a useless log force as well.
Reviewed-by: Alex Elder <aelder@sgi.com>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-04-07 21:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 1:57 [PATCH 0/9] xfs; candidate fixes for 2.6.39 V2 Dave Chinner
2011-04-07 1:57 ` [PATCH 1/9] xfs: fix extent format buffer allocation size Dave Chinner
2011-04-07 1:57 ` [PATCH 2/9] xfs: introduce a xfssyncd workqueue Dave Chinner
2011-04-07 21:34 ` Alex Elder
2011-04-08 0:41 ` Dave Chinner
2011-04-07 1:57 ` [PATCH 3/9] xfs: convert ENOSPC inode flushing to use new syncd workqueue Dave Chinner
2011-04-07 21:16 ` Alex Elder [this message]
2011-04-07 1:57 ` [PATCH 4/9] xfs: introduce background inode reclaim work Dave Chinner
2011-04-07 21:16 ` Alex Elder
2011-04-08 0:19 ` Dave Chinner
2011-04-08 13:49 ` Alex Elder
2011-04-07 1:57 ` [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue Dave Chinner
2011-04-07 21:16 ` Alex Elder
2011-04-07 1:57 ` [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c Dave Chinner
2011-04-07 21:16 ` Alex Elder
2011-04-07 1:57 ` [PATCH 7/9] xfs: push the AIL from memory reclaim and periodic sync Dave Chinner
2011-04-07 21:16 ` Alex Elder
2011-04-07 1:57 ` [PATCH 8/9] xfs: catch bad block numbers freeing extents Dave Chinner
2011-04-07 21:16 ` Alex Elder
2011-04-07 1:57 ` [PATCH 9/9] xfs: convert log tail checking to a warning Dave Chinner
2011-04-07 21:16 ` Alex Elder
-- strict thread matches above, loose matches on Subject: below --
2011-04-06 6:19 [PATCH 0/9] xfs: candidate fixes for 2.6.39 Dave Chinner
2011-04-06 6:19 ` [PATCH 3/9] xfs: convert ENOSPC inode flushing to use new syncd workqueue Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302210971.2576.599.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox