From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: David Sterba <dsterba@suse.cz>, xfs@oss.sgi.com
Subject: Re: [PATCH, v2] xfs: cleanup duplicate initializations
Date: Thu, 14 Apr 2011 09:50:39 -0500 [thread overview]
Message-ID: <1302792639.2608.6.camel@doink> (raw)
In-Reply-To: <20110413225327.GM31057@dastard>
On Thu, 2011-04-14 at 08:53 +1000, Dave Chinner wrote:
> On Wed, Apr 13, 2011 at 05:03:28PM -0500, Alex Elder wrote:
. . .
> > David, perhaps you could sign off on this version.
> > Meanwhile, another reviewer might make sense.
>
> Seeing as you only added a hunk, I'd say that keeping his old
> sіgnoff is just fine.
OK.
> >
> > -Alex
> >
> > follow these guidelines:
> > - leave initialization in the declaration block if it fits the line
> > - move to the code where it's more suitable ('for' init block)
> >
> > Originally proposed by David Sterba <dsterba@suse.cz>
>
> That is what the "From:" tag is for when you post someone else's
> patch. ;)
Good to know. Thanks a lot for the review.
> Anyway, looks good now.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
> Cheers,
>
> Dave.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-04-14 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 17:12 [PATCH] xfs: cleanup duplicate initializations David Sterba
2011-03-28 18:52 ` Alex Elder
2011-04-13 22:03 ` [PATCH, v2] " Alex Elder
2011-04-13 22:53 ` Dave Chinner
2011-04-14 14:50 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302792639.2608.6.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=dsterba@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox