From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>, xfs@oss.sgi.com
Subject: Re: xfs build warning
Date: Thu, 21 Apr 2011 15:08:10 -0500 [thread overview]
Message-ID: <1303416490.2581.518.camel@doink> (raw)
In-Reply-To: <20110415173902.GA27378@infradead.org>
On Fri, 2011-04-15 at 13:39 -0400, Christoph Hellwig wrote:
> On Fri, Apr 15, 2011 at 09:48:02AM -0700, Randy Dunlap wrote:
> > on i386, when CONFIG_LBDAF is not enabled:
> >
> > fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'
>
> This should fix it:
Looks good. Christoph, can I assume your signoff?
I wonder whether we'll ever need to cast the other
fields that are based on abstractions from __uint32_t
(like xfs_agblock_t, xfs_extlen_t, ...).
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-04-21 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 16:48 xfs build warning Randy Dunlap
2011-04-15 17:39 ` Christoph Hellwig
2011-04-15 17:47 ` Randy Dunlap
2011-04-21 20:08 ` Alex Elder [this message]
2011-04-22 4:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303416490.2581.518.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=randy.dunlap@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox