From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/4] xfs: candidate fixes for 2.6.39-rc4
Date: Thu, 21 Apr 2011 15:48:50 -0500 [thread overview]
Message-ID: <1303418930.2581.546.camel@doink> (raw)
In-Reply-To: <1303360144-10632-1-git-send-email-david@fromorbit.com>
On Thu, 2011-04-21 at 14:29 +1000, Dave Chinner wrote:
> This is my current bug fix stack. They are probably all candidates
> for 2.6.39, though I don't mind if we put any of them off
> until.40...
I thought I had said so before on the first three of
these but I guess not. They look good to me.
Reviewed-by: Alex Elder <aelder@sgi.com>
As far as whether to send them to Linus for
2.6.39--I think they'd all four be OK, but
none of them are (recent) regressions and I'm
on a pretty good long streak of not getting
flamed by Linus. So unless you feel strongly
about it, I'm going to hold them for 2.6.40.
The fourth one I have been following along on the
sidelines without really looking closely at the
code involved. Now that you and Lachlan seem to
have agreed on this tiny fix I'll take a much
closer look, as I consider all your discussion
along the way.
However, without even doing that I'm OK with
committing it, since I think the change is
very small, it fixes the test 250 crash issue,
and the worst it would do appears to be exhausting
space just a little earlier when it's almost
gone already.
So I'm prepared to pull this series when you
request it. I'm testing with it right now and
have seen no trouble.
Oh, except that test 250 appears to have no
saved golden output, and the test itself may
need a little work to allow for that. (Will
you look into that?)
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-04-21 20:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 4:29 [PATCH 0/4] xfs: candidate fixes for 2.6.39-rc4 Dave Chinner
2011-04-21 4:29 ` [PATCH 1/4] xfs: fix xfs_itruncate_start tracing Dave Chinner
2011-04-21 4:29 ` [PATCH 2/4] xfs: don't look forever in xfs_inode_ag_walk during async inode flushes Dave Chinner
2011-04-21 4:29 ` [PATCH 3/4] xfs: reset buffer pointers before freeing them Dave Chinner
2011-04-21 4:52 ` Christoph Hellwig
2011-04-21 6:53 ` Dave Chinner
2011-04-21 4:29 ` [PATCH 4/4] xfs: obey minleft values during extent allocation correctly Dave Chinner
2011-04-21 4:44 ` Christoph Hellwig
2011-04-21 5:05 ` Lachlan McIlroy
2011-04-21 6:53 ` Dave Chinner
2011-04-21 13:48 ` Lachlan McIlroy
2011-04-21 20:48 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303418930.2581.546.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox