From: Joe Perches <joe@perches.com>
To: aelder@sgi.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Remove duplicate XFS from xfs_alert_tag, neatening
Date: Tue, 26 Apr 2011 13:54:08 -0700 [thread overview]
Message-ID: <1303851248.24299.60.camel@Joe-Laptop> (raw)
In-Reply-To: <1303850805.2080.164.camel@doink>
On Tue, 2011-04-26 at 15:46 -0500, Alex Elder wrote:
> On Thu, 2011-04-21 at 14:08 -0700, Joe Perches wrote:
> > The xfs_printk in xfs_alert_tag doesn't need an XFS: prefix
> > as it's added by xfs_printk.
> > Add format checking to the non-debug inline function xfs_debug.
> > Miscellaneous function prototype argument alignment.
[]
> I'll highlight the fact that this was the last caller of
> xfs_printk(). As such I think it should just be eliminated,
> and make the use of xfs_info() or xfs_debug() mandatory.
> They are clean, easy, and have meaningful enough names
> that this should be fine. (What do others think?)
I only wanted to point out the unnecessary "XFS:" duplication.
Taking out xfs_printk would save some text & data.
Do what you think appropriate.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-04-26 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 21:08 [PATCH] xfs: Remove duplicate XFS from xfs_alert_tag, neatening Joe Perches
2011-04-26 20:46 ` Alex Elder
2011-04-26 20:54 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303851248.24299.60.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox