[PATCH] xfsprogs - resolve Debian readline build issue

[PATCH] xfsprogs - resolve Debian readline build issue

[Nathan Scott]

Address the recently reported build issue with libreadline5/6, via
the gplv2 route.  Since this appears to be a relatively recent pkg,
I made its use conditional so the deb build continues to work for
everyone not running a bleeding edge distro.  Works For Me (tm).

This addresses Debian bug 553875: libreadline5-dev removal pending

Signed-off-by: Nathan Scott <nathans@debian.org>

diff --git a/debian/control b/debian/control
index 401cdab..f813a43 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: admin
 Priority: optional
 Maintainer: XFS Development Team <xfs@oss.sgi.com>
 Uploaders: Nathan Scott <nathans@debian.org>, Anibal Monsalve Salazar <anibal@debian.org>
-Build-Depends: uuid-dev, autoconf, debhelper (>= 5), gettext, libtool, libreadline5-dev, libblkid-dev (>= 2.17)
+Build-Depends: uuid-dev, autoconf, debhelper (>= 5), gettext, libtool, libreadline5-dev | libreadline-gplv2-dev, libblkid-dev (>= 2.17)
 Standards-Version: 3.9.1
 Homepage: http://oss.sgi.com/projects/xfs/
 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsprogs - resolve Debian readline build issue

[Alex Elder]

On Fri, 2011-04-29 at 09:15 +1000, Nathan Scott wrote:
> Address the recently reported build issue with libreadline5/6, via
> the gplv2 route.  Since this appears to be a relatively recent pkg,
> I made its use conditional so the deb build continues to work for
> everyone not running a bleeding edge distro.  Works For Me (tm).
> 
> This addresses Debian bug 553875: libreadline5-dev removal pending

As far as I'm concerned, this looks fine.

I understand the issue, but I'm not really
familiar with the Debian build/dependency
system at work here, so I'm not really a
very qualified reviewer.  But if you're
comfortable with it and get nobody else to
review it, you are welcome to use my sign-off.

Signed-off-by: Alex Elder <aelder@sgi.com>

> Signed-off-by: Nathan Scott <nathans@debian.org>


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsprogs - resolve Debian readline build issue

[Nathan Scott]

----- Original Message -----
> On Fri, 2011-04-29 at 09:15 +1000, Nathan Scott wrote:
> > Address the recently reported build issue with libreadline5/6, via
> > the gplv2 route. Since this appears to be a relatively recent pkg,
> > I made its use conditional so the deb build continues to work for
> > everyone not running a bleeding edge distro. Works For Me (tm).
> >
> > This addresses Debian bug 553875: libreadline5-dev removal pending
> 
> As far as I'm concerned, this looks fine.
> 
> I understand the issue, but I'm not really
> familiar with the Debian build/dependency
> system at work here, so I'm not really a
> very qualified reviewer. But if you're
> comfortable with it and get nobody else to
> review it, you are welcome to use my sign-off.

Thanks!  I'll give it a couple more days then commit it if noone else
has further input.

cheers.

-- 
Nathan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs