From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p44EQNR0079352 for ; Wed, 4 May 2011 09:26:23 -0500 Subject: Re: [PATCH] xfs: kill off xfs_printk() From: Alex Elder In-Reply-To: <20110504004453.GC9114@dastard> References: <20110504004453.GC9114@dastard> Date: Wed, 4 May 2011 09:29:58 -0500 Message-ID: <1304519398.2841.12.camel@doink> MIME-Version: 1.0 Reply-To: aelder@sgi.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: Joe Perches , xfs@oss.sgi.com On Wed, 2011-05-04 at 10:44 +1000, Dave Chinner wrote: > On Tue, May 03, 2011 at 03:14:44PM -0500, Alex Elder wrote: > > From: Joe Perches > > > > xfs_alert_tag() can be defined using xfs_alert(), and thereby avoid > > using xfs_printk() altogether. This is the only remaining use of > > xfs_printk(), so changing it this way means xfs_printk() can simply > > be eliminated.can simply be eliminated.can simply be eliminated.can > > simply be eliminated.can simply be eliminated.can simply be > > eliminated.can simply be eliminated.can simply be eliminated.can > > simply be eliminated. > > > > Also add format checking to the non-debug inline function xfs_debug. > > Miscellaneous function prototype argument alignment. > > > > (Updated to delete the definition of xfs_printk(), which is > > no longer used or needed.) > > > > Signed-off-by: Alex Elder > > If you are going to credit Joe as the original source of the patch > in the commit (i.e. via the "From:" tag), you probably should copy > in his original Signed-off-by tag as well.... Honestly I wasn't sure about that. Since I changed it I kind of hoped he'd acknowledge or sign off on it. I guess I'm still learning about the conventions for signing off on things. I want to give all credit properly, I just don't always know the Right Way to do so. -Alex _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs