From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix duplicate workqueue initialisation
Date: Tue, 10 May 2011 09:43:27 -0500 [thread overview]
Message-ID: <1305038607.2962.10.camel@doink> (raw)
In-Reply-To: <20110510053319.GA3047@infradead.org>
On Tue, 2011-05-10 at 01:33 -0400, Christoph Hellwig wrote:
> On Tue, May 10, 2011 at 12:05:50PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > The workqueue initialisation function is called twice when
> > initialising the XFS subsystem. Remove the second initialisation
> > call.
>
> Not sure how we got there, but it looks indeed buggy. I'm kinda
> surprised the workqueue code didn't blow up with the duplicate names.
Maybe duplicated by a merge along the way?
The second set of workqueues prevails, leaving the originals
unused and leaked. In fact, an xfs module can probably even
unload cleanly because it doesn't really "own" the workqueue,
which by itself is an interesting artifact.
This is clearly a bug but I don't think it is truly harmful,
so I am not going to send it to Linus for 2.6.39. If you
disagree, let me know and I'll send it separately.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-05-10 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 2:05 [PATCH] xfs: fix duplicate workqueue initialisation Dave Chinner
2011-05-10 5:33 ` Christoph Hellwig
2011-05-10 14:43 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305038607.2962.10.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox