* [PATCH] xfs: fix duplicate workqueue initialisation
@ 2011-05-10 2:05 Dave Chinner
2011-05-10 5:33 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2011-05-10 2:05 UTC (permalink / raw)
To: xfs
From: Dave Chinner <dchinner@redhat.com>
The workqueue initialisation function is called twice when
initialising the XFS subsystem. Remove the second initialisation
call.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/linux-2.6/xfs_super.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c
index 29c0ccb..365375c 100644
--- a/fs/xfs/linux-2.6/xfs_super.c
+++ b/fs/xfs/linux-2.6/xfs_super.c
@@ -1800,10 +1800,6 @@ init_xfs_fs(void)
if (error)
goto out_cleanup_procfs;
- error = xfs_init_workqueues();
- if (error)
- goto out_sysctl_unregister;
-
vfs_initquota();
error = register_filesystem(&xfs_fs_type);
--
1.7.4.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: fix duplicate workqueue initialisation
2011-05-10 2:05 [PATCH] xfs: fix duplicate workqueue initialisation Dave Chinner
@ 2011-05-10 5:33 ` Christoph Hellwig
2011-05-10 14:43 ` Alex Elder
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2011-05-10 5:33 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs
On Tue, May 10, 2011 at 12:05:50PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The workqueue initialisation function is called twice when
> initialising the XFS subsystem. Remove the second initialisation
> call.
Not sure how we got there, but it looks indeed buggy. I'm kinda
surprised the workqueue code didn't blow up with the duplicate names.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: fix duplicate workqueue initialisation
2011-05-10 5:33 ` Christoph Hellwig
@ 2011-05-10 14:43 ` Alex Elder
0 siblings, 0 replies; 3+ messages in thread
From: Alex Elder @ 2011-05-10 14:43 UTC (permalink / raw)
To: Dave Chinner; +Cc: Christoph Hellwig, xfs
On Tue, 2011-05-10 at 01:33 -0400, Christoph Hellwig wrote:
> On Tue, May 10, 2011 at 12:05:50PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > The workqueue initialisation function is called twice when
> > initialising the XFS subsystem. Remove the second initialisation
> > call.
>
> Not sure how we got there, but it looks indeed buggy. I'm kinda
> surprised the workqueue code didn't blow up with the duplicate names.
Maybe duplicated by a merge along the way?
The second set of workqueues prevails, leaving the originals
unused and leaked. In fact, an xfs module can probably even
unload cleanly because it doesn't really "own" the workqueue,
which by itself is an interesting artifact.
This is clearly a bug but I don't think it is truly harmful,
so I am not going to send it to Linus for 2.6.39. If you
disagree, let me know and I'll send it separately.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-10 14:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-10 2:05 [PATCH] xfs: fix duplicate workqueue initialisation Dave Chinner
2011-05-10 5:33 ` Christoph Hellwig
2011-05-10 14:43 ` Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox