From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/4] xfs: PF_FSTRANS should never be set in ->writepage
Date: Tue, 24 May 2011 21:18:49 -0500 [thread overview]
Message-ID: <1306289929.2823.120.camel@doink> (raw)
In-Reply-To: <20110428130514.146517168@bombadil.infradead.org>
On Thu, 2011-04-28 at 08:55 -0400, Christoph Hellwig wrote:
> Now that we reject direct reclaim in addition to always using GFP_NOFS
> allocation there's no chance we'll ever end up in ->writepage with
> PF_FSTRANS set. Add a WARN_ON if we hit this case, and stop checking
> if we'd actually need to start a transaction.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Do the radix_tree_preload(GFP_KERNEL) calls in
xfs_iget_cache_miss() and xfs_mru_cache_insert()
pose any risk here? (I haven't really looked
closely, I just noticed that these were cases we
did not use GFP_NOFS.)
Outside of that, this looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-05-25 2:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 12:55 [PATCH 0/4] use write_cache_pages Christoph Hellwig
2011-04-28 12:55 ` [PATCH 1/4] xfs: PF_FSTRANS should never be set in ->writepage Christoph Hellwig
2011-05-25 2:18 ` Alex Elder [this message]
2011-05-25 7:46 ` Christoph Hellwig
2011-04-28 12:55 ` [PATCH 2/4] xfs: remove the unused ilock_nowait codepath in writepage Christoph Hellwig
2011-05-25 2:18 ` Alex Elder
2011-04-28 12:55 ` [PATCH 3/4] xfs: use write_cache_pages for writeback clustering Christoph Hellwig
2011-04-28 12:55 ` [PATCH 4/4] xfs: cleanup xfs_add_to_ioend Christoph Hellwig
2011-04-29 0:40 ` [PATCH 0/4] use write_cache_pages Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306289929.2823.120.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox