From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs: make log devices with write back caches work
Date: Thu, 16 Jun 2011 11:32:54 -0500 [thread overview]
Message-ID: <1308241974.2717.1.camel@doink> (raw)
In-Reply-To: <20110616120223.GA9854@infradead.org>
On Thu, 2011-06-16 at 08:02 -0400, Christoph Hellwig wrote:
> There's no reason not to support cache flushing on external log devices.
> The only thing this really requires is flushing the data device first
> both in fsync and log commits. A side effect is that we also have to
> remove the barrier write test during mount, which has been superflous
> since the new FLUSH+FUA code anyway. Also use the chance to flush the
> RT subvolume write cache before the fsync commit, which is required
> for correct semantics.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Thanks for the explanations and update. This looks good.
I'm testing now and barring a problem should be to Linus
this weekend.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-06-16 16:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 12:02 [PATCH v2] xfs: make log devices with write back caches work Christoph Hellwig
2011-06-16 16:32 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308241974.2717.1.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox