From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] xfs: clear XFS_IDIRTY_RELEASE on truncate down
Date: Thu, 23 Jun 2011 16:59:36 -0500 [thread overview]
Message-ID: <1308866376.2010.33.camel@doink> (raw)
In-Reply-To: <1308792901-22880-3-git-send-email-david@fromorbit.com>
On Thu, 2011-06-23 at 11:35 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> When an inode is truncated down, speculative preallocation is
> removed from the inode. This should also reset the state bits for
> controlling whether preallocation is subsequently removed when the
> file is next closed. The flag is not being cleared, so repeated
> operations on a file that first involve a truncate (e.g. multiple
> repeated dd invocations on a file) give different file layouts for
> the second and subsequent invocations.
>
> Fix this by clearing the XFS_IDIRTY_RELEASE state bit when the
> XFS_ITRUNCATED bit is detected in xfs_release() and hence ensure
> that speculative delalloc is removed on files that have been
> truncated down.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-06-23 21:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 1:34 [PATCH 0/3] xfs: fixes for 3.0-rc4 Dave Chinner
2011-06-23 1:34 ` [PATCH 1/3] xfs: reset inode per-lifetime state when recycling it Dave Chinner
2011-06-23 21:21 ` Christoph Hellwig
2011-06-23 21:58 ` Alex Elder
2011-06-23 1:35 ` [PATCH 2/3] xfs: clear XFS_IDIRTY_RELEASE on truncate down Dave Chinner
2011-06-23 21:21 ` Christoph Hellwig
2011-06-23 21:59 ` Alex Elder [this message]
2011-06-23 1:35 ` [PATCH 3/3] xfs: prevent bogus assert when trying to remove non-existent attribute Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308866376.2010.33.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox