* Re: sbcount comment change
[not found] <1309366188.5505.6215.camel@chandra-lucid.beaverton.ibm.com>
@ 2011-06-29 18:36 ` Alex Elder
0 siblings, 0 replies; only message in thread
From: Alex Elder @ 2011-06-29 18:36 UTC (permalink / raw)
To: sekharan; +Cc: xfs
On Wed, 2011-06-29 at 09:49 -0700, Chandra Seetharaman wrote:
> Hi Alex,
>
> Does this look fine ?
Yes. But it's small enough that I think you should just
include this change with another change (especially if you
decide to drop the "sync" flag from this function as I
suggested).
-Alex
> --------------
> @@ -1568,18 +1568,14 @@ xfs_fs_writable(xfs_mount_t *mp)
> /*
> * xfs_log_sbcount
> *
> - * Called either periodically to keep the on disk superblock values
> - * roughly up to date or from unmount to make sure the values are
> - * correct on a clean unmount.
> + * Sync the superblock counters to disk.
> *
> * Note this code can be called during the process of freezing, so
> - * we may need to use the transaction allocator which does not not
> + * we may need to use the transaction allocator which does not
> * block when the transaction subsystem is in its frozen state.
> */
> ----------------
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-06-29 18:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1309366188.5505.6215.camel@chandra-lucid.beaverton.ibm.com>
2011-06-29 18:36 ` sbcount comment change Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox