From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p5TLwWQj144941 for ; Wed, 29 Jun 2011 16:58:32 -0500 Subject: Re: [PATCH] xfs: replace bp->flags usage with predefined macros From: Alex Elder In-Reply-To: <1309379623.5505.6222.camel@chandra-lucid.beaverton.ibm.com> References: <1309308784.5505.6214.camel@chandra-lucid.beaverton.ibm.com> <20110629044616.GB1026@dastard> <20110629063001.GA12554@infradead.org> <1309379623.5505.6222.camel@chandra-lucid.beaverton.ibm.com> Date: Wed, 29 Jun 2011 16:58:26 -0500 Message-ID: <1309384706.8649.31.camel@doink> MIME-Version: 1.0 Reply-To: aelder@sgi.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: sekharan@us.ibm.com Cc: Christoph Hellwig , XFS Mailing List On Wed, 2011-06-29 at 13:33 -0700, Chandra Seetharaman wrote: > On Wed, 2011-06-29 at 02:30 -0400, Christoph Hellwig wrote: > > On Wed, Jun 29, 2011 at 02:46:16PM +1000, Dave Chinner wrote: > > > On Tue, Jun 28, 2011 at 05:53:04PM -0700, Chandra Seetharaman wrote: > > > > Cleanup: Replace bp->flags usage with predefined macros. > > > > > > > > Signed-off-by: Chandra Seetharaman > > > > > > Christoph can correct me if I'm wrong, but I'm pretty sure his long term > > > direction is to remove the XFS_BUF_* macros completely. > > > > Yes, at least those that are simpler flags get/set/clear wrappers. > > So, the suggestion is to go the other way and remove all the wrappers > and use bp->flags directly ? Yes, that's right. Sorry about that. Chandra asked me for some things to do on XFS so I fired a few small simple odds and ends I had made note of along the way. This was one--I said that the use of macros should be consistent. I said we should eventually do away with them entirely, but I didn't recommend he do that right now since this was being done by a new contributor. Chandra, I think if you're up to it, doing away with the macros is the right way to go. -Alex _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs