From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15])
	by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id
	p663XX78063676 for <xfs@oss.sgi.com>; Tue, 5 Jul 2011 22:33:33 -0500
Subject: Re: [PATCH 15/27] xfs: cleanup the defintion of struct
	xfs_dir2_sf_entry
From: Alex Elder <aelder@sgi.com>
In-Reply-To: <20110701094605.415405585@bombadil.infradead.org>
References: <20110701094321.936534538@bombadil.infradead.org>
	<20110701094605.415405585@bombadil.infradead.org>
Date: Tue, 5 Jul 2011 22:33:31 -0500
Message-ID: <1309923211.3381.27.camel@doink>
MIME-Version: 1.0
Reply-To: aelder@sgi.com
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: xfs-bounces@oss.sgi.com
Errors-To: xfs-bounces@oss.sgi.com
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com

On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> Remove the inumber member which is at a variable offset after the actual
> name, and make name a real variable sized C99 array instead of the incorrect
> one-sized array which confuses (not only) gcc.  Based on this clean up
> the helpers to calculate the entry size.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Why was the inode put after then name in the
first place?

Anyway, looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs