Re: [PATCH 13/27] xfs: cleanup shortform directory inode number handling

Alex Elder
2011-07-05T22:36:55Z

On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> Refactor the shortform directory helpers that deal with the 32-bit vs
> 64-bit wide inode numbers into more sensible helpers, and kill the
> xfs_intino_t typedef that is now superflous.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>

Looking at XFS_{GET,PUT}_DIR_INO{4,8}(), they could
maybe benefit from conversion to cpu_to_be32() and
friends. They're only used in these few spots.

Looks good though.

Reviewed-by: Alex Elder <aelder@sgi.com>