Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags

Alex Elder
2011-07-06T04:09:20Z

On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> Remove the unused and misnamed _XBF_RUN_QUEUES flag, rename XBF_LOG_BUFFER
> to the more fitting XBF_SYNCIO, and split XBF_ORDERED into XBF_FUA and
> XBF_FLUSH to allow more fine grained control over the bio flags. Also
> cleanup processing of the flags in _xfs_buf_ioapply to make more sense,
> and renumber the sparse flag number space to group flags by purpose.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Interesting that _XBF_RUN_QUEUES was never actually used.
The new names are much more understandable. Looks like
READ_META and WRITE_META are now effectively gone...

Looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>