Re: [PATCH 17/27] xfs: kill struct xfs_dir2_block

Alex Elder
2011-07-06T03:37:00Z

On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> Remove the confusing xfs_dir2_block structure. It is supposed to describe
> an XFS dir2 block format btree block, but due to the variable sized nature
> of almost all elements in it it can't actuall do anything close to that
> job. In addition to accessing the fixed offset header structure it was
> only used to get a pointer to the first dir or unused entry after it,
> which can be trivially replaced by pointer arithmetics on the header
> pointer. For most users that is actually more natural anyway, as they
> don't use a typed pointer but rather a character pointer for further
> arithmetics.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Yes, I think this is an improvement.

Reviewed-by: Alex Elder <aelder@sgi.com>