From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p67LFJHF195404 for ; Thu, 7 Jul 2011 16:15:19 -0500 Subject: Re: [PATCH 4/5] xfs: convert AIL cursors to use struct list_head From: Alex Elder In-Reply-To: <1309757260-5484-5-git-send-email-david@fromorbit.com> References: <1309757260-5484-1-git-send-email-david@fromorbit.com> <1309757260-5484-5-git-send-email-david@fromorbit.com> Date: Thu, 7 Jul 2011 16:15:15 -0500 Message-ID: <1310073315.1980.79.camel@doink> MIME-Version: 1.0 Reply-To: aelder@sgi.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com T24gTW9uLCAyMDExLTA3LTA0IGF0IDE1OjI3ICsxMDAwLCBEYXZlIENoaW5uZXIgd3JvdGU6Cj4g RnJvbTogRGF2ZSBDaGlubmVyIDxkY2hpbm5lckByZWRoYXQuY29tPgo+IAo+IFRoZSBsaXN0IG9m IGFjdGl2ZSBBSUwgY3Vyc29ycyB1c2VzIGEgcm9sbC15b3VyLW93biBsaW5rZWQgbGlzdCB3aXRo Cj4gc3BlY2lhbCBjYXNpbmcgZm9yIHRoZSBBSUwgcHVzaCBjdXJzb3IuIFNpbXBsaWZ5IHRoaXMg Y29kZSBieQo+IHJlcGxhY2luZyB0aGUgbGlzdCB3aXRoIHN0YW5kYXJkIHN0cnVjdCBsaXN0X2hl YWQgbGlzdHMsIGFuZCB1c2UgYQo+IHNlcGFyYXRlIGxpc3RfaGVhZCB0byB0cmFjayB0aGUgYWN0 aXZlIGN1cnNvcnMgc28gdGhhdCB0aGUgY29kZSBjYW4KPiBqdXN0IHRyZWF0IHRoZSBBSUwgcHVz aCBjdXJzb3IgKHdoaWNoIGlzIHN0aWxsIGVtYmVkZGVkIGludG8gdGhlCj4gc3RydWN0IHhmc19h aWwpIGFzIGEgZ2VuZXJpYyBjdXJzb3IuCj4gCj4gRnVydGhlciwgZml4IHRoZSBkdXBsaWNhdGUg cHVzaCBjdXJzb3IgaW5pdGlhbGlzYXRpb24gdGhhdCB0aGUKPiBzcGVjaWFsIGNhc2UgaGFuZGxp bmcgd2FzIGhpZGluZywgYW5kIGNsZWFuIHVwIGFsbCB0aGUgY29tbWVudHMKPiBhcm91bmQgdGhl IGFjdGl2ZSBjdXJzb3IgbGlzdCBoYW5kbGluZy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBEYXZlIENo aW5uZXIgPGRjaGlubmVyQHJlZGhhdC5jb20+CgpJIHN1Z2dlc3QgYSBmZXcgY29tbWVudCBjaGFu Z2VzIGJlbG93LiAgSSBhbHNvIGhhdmUgYQpxdWVzdGlvbiBhYm91dCB3aHkgdGhlIHB1c2ggY3Vy c29yIGlzbid0IHRyZWF0ZWQKbGlrZSBhbnkgb3RoZXIgY3Vyc29ycy4gIEkgYWRkZWQgYSBmZXcg Yml0cyBvZgpjb21tZW50YXJ5IGFzIHdlbGwtLXlvdSBhZGRyZXNzZWQgYSBmZXcgdGhpbmdzCkkg aGFkIGJlZW4gdGhpbmtpbmcgYWJvdXQgZWFybGllci4KCkkgZ3Vlc3MgSSdtIGludGVyZXN0ZWQg aW4geW91ciByZXNwb25zZSBiZWZvcmUKc2lnbmluZyBvZmYuCgoJCQkJCS1BbGV4Cgo+IC0tLQo+ ICBmcy94ZnMveGZzX3RyYW5zX2FpbC5jICB8ICAgNjggKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBmcy94ZnMveGZzX3RyYW5zX3ByaXYuaCB8ICAgIDUg KystCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgNDggZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2ZzL3hmcy94ZnNfdHJhbnNfYWlsLmMgYi9mcy94ZnMveGZzX3Ry YW5zX2FpbC5jCj4gaW5kZXggZGU3YTUyYS4uM2I1YjVlNCAxMDA2NDQKPiAtLS0gYS9mcy94ZnMv eGZzX3RyYW5zX2FpbC5jCj4gKysrIGIvZnMveGZzL3hmc190cmFuc19haWwuYwo+IEBAIC0xNjUs MTUgKzE2NSwxMSBAQCB4ZnNfYWlsX21heF9sc24oCj4gIC8qCj4gICAqIEFJTCB0cmF2ZXJzYWwg Y3Vyc29yIGluaXRpYWxpc2F0aW9uLgo+ICAgKgo+IC0gKiBUaGUgY3Vyc29yIGtlZXBzIHRyYWNr IG9mIHdoZXJlIG91ciBjdXJyZW50IHRyYXZlcnNhbCBpcyB1cAo+IC0gKiB0byBieSB0cmFja2lu ZyB0aGUgbmV4dCDGo3RlbSBpbiB0aGUgbGlzdCBmb3IgdXMuIEhvd2V2ZXIsIGZvcgo+IC0gKiB0 aGlzIHRvIGJlIHNhZmUsIHJlbW92aW5nIGFuIG9iamVjdCBmcm9tIHRoZSBBSUwgbmVlZHMgdG8g aW52YWxpZGF0ZQo+IC0gKiBhbnkgY3Vyc29yIHRoYXQgcG9pbnRzIHRvIGl0LiBoZW5jZSB0aGUg dHJhdmVyc2FsIGN1cnNvciBuZWVkcyB0bwo+IC0gKiBiZSBsaW5rZWQgdG8gdGhlIHN0cnVjdCB4 ZnNfYWlsIHNvIHRoYXQgZGVsZXRpb24gY2FuIHNlYXJjaCBhbGwgdGhlCj4gLSAqIGFjdGl2ZSBj dXJzb3JzIGZvciBpbnZhbGlkYXRpb24uCj4gLSAqCj4gLSAqIFdlIGRvbid0IGxpbmsgdGhlIHB1 c2ggY3Vyc29yIGJlY2F1c2UgaXQgaXMgZW1iZWRkZWQgaW4gdGhlIHN0cnVjdAo+IC0gKiB4ZnNf YWlsIGFuZCBoZW5jZSBlYXNpbHkgZmluZGFibGUuCj4gKyAqIFRoZSBjdXJzb3Iga2VlcHMgdHJh Y2sgb2Ygd2hlcmUgb3VyIGN1cnJlbnQgdHJhdmVyc2FsIGlzIHVwIHRvIGJ5IHRyYWNraW5nCj4g KyAqIHRoZSBuZXh0IMajdGVtIGluIHRoZSBsaXN0IGZvciB1cy4gSG93ZXZlciwgZm9yIHRoaXMg dG8gYmUgc2FmZSwgcmVtb3ZpbmcgYW4KICAgICAgICAgICAgICAgXgpXaGF0J3MgdXAgd2l0aCB0 aGUgd2VpcmQgbm9uLUFTQ0lJIGNoYXJhY3RlcnMgaW4geW91ciBjb2RlPwoKPiArICogb2JqZWN0 IGZyb20gdGhlIEFJTCBuZWVkcyB0byBpbnZhbGlkYXRlIGFueSBjdXJzb3IgdGhhdCBwb2ludHMg dG8gaXQuIGhlbmNlCj4gKyAqIHRoZSB0cmF2ZXJzYWwgY3Vyc29yIG5lZWRzIHRvIGJlIGxpbmtl ZCB0byB0aGUgc3RydWN0IHhmc19haWwgc28gdGhhdAo+ICsgKiBkZWxldGlvbiBjYW4gc2VhcmNo IGFsbCB0aGUgYWN0aXZlIGN1cnNvcnMgZm9yIGludmFsaWRhdGlvbi4KPiAgICovCj4gIFNUQVRJ QyB2b2lkCj4gIHhmc190cmFuc19haWxfY3Vyc29yX2luaXQoCj4gQEAgLTE4MSwxNyArMTc3LDEz IEBAIHhmc190cmFuc19haWxfY3Vyc29yX2luaXQoCj4gIAlzdHJ1Y3QgeGZzX2FpbF9jdXJzb3IJ KmN1cikKPiAgewo+ICAJY3VyLT5pdGVtID0gTlVMTDsKPiAtCWlmIChjdXIgPT0gJmFpbHAtPnhh X2N1cnNvcnMpCj4gLQkJcmV0dXJuOwo+IC0KPiAtCWN1ci0+bmV4dCA9IGFpbHAtPnhhX2N1cnNv cnMubmV4dDsKPiAtCWFpbHAtPnhhX2N1cnNvcnMubmV4dCA9IGN1cjsKPiArCUlOSVRfTElTVF9I RUFEKCZjdXItPmxpc3QpOwo+ICsJbGlzdF9hZGRfdGFpbCgmY3VyLT5saXN0LCAmYWlscC0+eGFf Y3Vyc29ycyk7CgpUaGlzIGlzIGdvb2QuICBJIHdhcyB0aGlua2luZyBhcyBJIGxvb2tlZCBhdCB0 aGlzIGVhcmxpZXIKdGhhdCBpdCB3b3VsZCBiZSBuaWNlciBpZiBuZXdlciBjdXJzb3JzIHdlcmUg YWRkZWQKdG8gdGhlIGVuZCBvZiB0aGUgbGlzdC4KCj4gIH0KPiAgCj4gIC8qCj4gLSAqIEdldCB0 aGUgbmV4dCBpdGVtIGluIHRoZSB0cmF2ZXJzYWwgYW5kIGFkdmFuY2UgdGhlIGN1cnNvci4KPiAt ICogSWYgdGhlIGN1cnNvciB3YXMgaW52YWxpZGF0ZWQgKGluaWRpY2F0ZWQgYnkgYSBsaXAgb2Yg MSksCj4gLSAqIHJlc3RhcnQgdGhlIHRyYXZlcnNhbC4KPiArICogR2V0IHRoZSBuZXh0IGl0ZW0g aW4gdGhlIHRyYXZlcnNhbCBhbmQgYWR2YW5jZSB0aGUgY3Vyc29yLiAgSWYgdGhlIGN1cnNvcgo+ ICsgKiB3YXMgaW52YWxpZGF0ZWQgKGluaWRpY2F0ZWQgYnkgYSBsaXAgb2YgMSksIHJlc3RhcnQg dGhlIHRyYXZlcnNhbC4KICAgICAgICAgICAgICAgICAgICAgICBpbmRpY2F0ZWQKCkFjdHVhbGx5 LCBpdCdzIGluZGljYXRlZCBieSBhIGxvdy1vcmRlciBiaXQgb2YgMS4gIFdoeSBpcyBpdAp0aGF0 IHlvdSBkZWNpZGVkIHRvIGp1c3Qgc2V0IHRoZSBiaXQgcmF0aGVyIHRoYW4gb3ZlcndyaXRlCnRo ZSBpdGVtIHBvaW50ZXI/ICBKdXN0IGZvciB0aGUgYmVuZWZpdCBvZiBkZWJ1Z2dpbmc/ICAoVGhh dAppcyBhIGdvb2QgcmVhc29uLi4uKSAgSWYgbm90LCBJIHN1Z2dlc3QgZGVmaW5pbmcgYW4KWEZT X0lURU1fSU5WQUxJRCBjb25zdGFudCBwb2ludGVyIHJhdGhlciB0aGFuIGp1c3QgdXNpbmcgMS4K Cj4gICAqLwo+ICBzdHJ1Y3QgeGZzX2xvZ19pdGVtICoKPiAgeGZzX3RyYW5zX2FpbF9jdXJzb3Jf bmV4dCgKPiBAQCAtMjA4LDM5ICsyMDAsMjQgQEAgeGZzX3RyYW5zX2FpbF9jdXJzb3JfbmV4dCgK PiAgfQo+ICAKPiAgLyoKPiAtICogTm93IHRoYXQgdGhlIHRyYXZlcnNhbCBpcyBjb21wbGV0ZSwg d2UgbmVlZCB0byByZW1vdmUgdGhlIGN1cnNvcgo+IC0gKiBmcm9tIHRoZSBsaXN0IG9mIHRyYXZl cnNpbmcgY3Vyc29ycy4gQXZvaWQgcmVtb3ZpbmcgdGhlIGVtYmVkZGVkCj4gLSAqIHB1c2ggY3Vy c29yLCBidXQgdXNlIHRoZSBmYWN0IGl0IGlzIGFsd2F5cyBwcmVzZW50IHRvIG1ha2UgdGhlCj4g LSAqIGxpc3QgZGVsZXRpb24gc2ltcGxlLgo+ICsgKiBXaGVuIHRoZSB0cmF2ZXJzYWwgaXMgY29t cGxldGUsIHdlIG5lZWQgdG8gcmVtb3ZlIHRoZSBjdXJzb3IgZnJvbSB0aGUgbGlzdAo+ICsgKiBv ZiB0cmF2ZXJzaW5nIGN1cnNvcnMuCj4gICAqLwo+ICB2b2lkCj4gIHhmc190cmFuc19haWxfY3Vy c29yX2RvbmUoCj4gIAlzdHJ1Y3QgeGZzX2FpbAkJKmFpbHAsCj4gLQlzdHJ1Y3QgeGZzX2FpbF9j dXJzb3IJKmRvbmUpCj4gKwlzdHJ1Y3QgeGZzX2FpbF9jdXJzb3IJKmN1cikKPiAgewo+IC0Jc3Ry dWN0IHhmc19haWxfY3Vyc29yCSpwcmV2ID0gTlVMTDsKPiAtCXN0cnVjdCB4ZnNfYWlsX2N1cnNv cgkqY3VyOwo+IC0KPiAtCWRvbmUtPml0ZW0gPSBOVUxMOwoKVGhpcyBlbGltaW5hdGVzIHRoZSBj dXJpb3VzIHNpdHVhdGlvbiB3aGVyZSB0aGUKZW5kIG9mIHRoZSBsaXN0IHdhcyBtYXJrZWQgYnkg YSBudWxsICppdGVtKiBwb2ludGVyCnJhdGhlciB0aGFuIHNvbWV0aGluZyBoYXZpbmcgdG8gZG8g d2l0aCB0aGUgbmV4dApwb2ludGVyLgoKPiAtCWlmIChkb25lID09ICZhaWxwLT54YV9jdXJzb3Jz KQo+IC0JCXJldHVybjsKPiAtCXByZXYgPSAmYWlscC0+eGFfY3Vyc29yczsKPiAtCWZvciAoY3Vy ID0gcHJldi0+bmV4dDsgY3VyOyBwcmV2ID0gY3VyLCBjdXIgPSBwcmV2LT5uZXh0KSB7Cj4gLQkJ aWYgKGN1ciA9PSBkb25lKSB7Cj4gLQkJCXByZXYtPm5leHQgPSBjdXItPm5leHQ7Cj4gLQkJCWJy ZWFrOwoKLiAuIC4KCj4gLSAqIGludmFsaWRhdGlvbiBhbmQgdGhlIGVuZCBvZiB0aGUgbGlzdCB3 aGVuIGdldHRpbmcgdGhlIG5leHQgaXRlbQo+ICsgKiBJbnZhbGlkYXRlIGFueSBjdXJzb3IgdGhh dCBpcyBwb2ludGluZyB0byB0aGlzIGl0ZW0uIFRoaXMgaXMgY2FsbGVkIHdoZW4gYW4KPiArICog aXRlbSBpcyByZW1vdmVkIGZyb20gdGhlIEFJTC4gQW55IGN1cnNvciBwb2ludGluZyB0byB0aGlz IG9iamVjdCBpcyBub3cKPiArICogaW52YWxpZCBhbmQgdGhlIHRyYXZlcnNhbCBuZWVkcyB0byBi ZSB0ZXJtaW5hdGVkIHNvIGl0IGRvZXNuJ3QgcmVmZXJlbmNlIGEKPiArICogZnJlZWQgb2JqZWN0 LiBXZSBzZXQgdGhlIGN1cnNvciBpdGVtIHRvIGEgdmFsdWUgb2YgMSBzbyB3ZSBjYW4gZGlzdGlu Z3Vpc2gKCkZpeCB0aGlzIGNvbW1lbnQgdG8gcmVmbGVjdCB0aGUgdXNlIG9mIHRoZSBsb3cgYml0 IHJhdGhlciB0aGFuIGp1c3QgMS4KCj4gKyAqIGJldHdlZW4gYW4gaW52YWxpZGF0aW9uIGFuZCB0 aGUgZW5kIG9mIHRoZSBsaXN0IHdoZW4gZ2V0dGluZyB0aGUgbmV4dCBpdGVtCj4gICAqIGZyb20g dGhlIGN1cnNvci4KPiAgICovCj4gIFNUQVRJQyB2b2lkCgouIC4gLgoKPiBudF90KWN1ci0+aXRl bSB8IDEpOwo+IEBAIC00MTYsNyArMzkyLDcgQEAgeGZzX2FpbF93b3JrZXIoCj4gIAlzdHJ1Y3Qg eGZzX2FpbAkJKmFpbHAgPSBjb250YWluZXJfb2YodG9fZGVsYXllZF93b3JrKHdvcmspLAo+ICAJ CQkJCXN0cnVjdCB4ZnNfYWlsLCB4YV93b3JrKTsKPiAgCXhmc19tb3VudF90CQkqbXAgPSBhaWxw LT54YV9tb3VudDsKPiAtCXN0cnVjdCB4ZnNfYWlsX2N1cnNvcgkqY3VyID0gJmFpbHAtPnhhX2N1 cnNvcnM7Cj4gKwlzdHJ1Y3QgeGZzX2FpbF9jdXJzb3IJKmN1ciA9ICZhaWxwLT54YV9wdXNoX2N1 cnNvcjsKCklzIHRoZSBwdXNoIGN1cnNvciBkZWZpbmVkIGluIHRoZSBhaWwgc3RydWN0dXJlIGp1 c3QKc28gaXQncyBlYXNpZXIgdG8gZmluZD8KCj4gIAl4ZnNfbG9nX2l0ZW1fdAkJKmxpcDsKPiAg CXhmc19sc25fdAkJbHNuOwo+ICAJeGZzX2xzbl90CQl0YXJnZXQ7Cj4gQEAgLTQyOCw3ICs0MDQs NiBAQCB4ZnNfYWlsX3dvcmtlcigKPiAgCj4gIAlzcGluX2xvY2soJmFpbHAtPnhhX2xvY2spOwo+ ICAJdGFyZ2V0ID0gYWlscC0+eGFfdGFyZ2V0Owo+IC0JeGZzX3RyYW5zX2FpbF9jdXJzb3JfaW5p dChhaWxwLCBjdXIpOwoKSSBkb24ndCBzZWUgd2h5IHRoZSBwdXNoIGN1cnNvciBzaG91bGQgYmUg dHJlYXRlZAphbnkgZGlmZmVyZW50bHkgZnJvbSBhbnkgb3RoZXJzLiAgSWYgc29tZXRoaW5nIGdl dHMKaW52YWxpZGF0ZWQgdGhlIHB1c2ggY3Vyc29yIG5lZWRzIHRvIGJlIG5vdGlmaWVkCmFsc28s IGRvZXNuJ3QgaXQ/CgpJIG11c3QgYmUgbWlzc2luZyBzb21ldGhpbmcgaGVyZS4uLgoKPiAgCWxp cCA9IHhmc190cmFuc19haWxfY3Vyc29yX2ZpcnN0KGFpbHAsIGN1ciwgYWlscC0+eGFfbGFzdF9w dXNoZWRfbHNuKTsKPiAgCWlmICghbGlwIHx8IFhGU19GT1JDRURfU0hVVERPV04obXApKSB7Cj4g IAkJLyoKCi4gLiAuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwp4ZnMgbWFpbGluZyBsaXN0Cnhmc0Bvc3Muc2dpLmNvbQpodHRwOi8vb3NzLnNnaS5jb20v bWFpbG1hbi9saXN0aW5mby94ZnMK