From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 03/11] xfs: factor out xfs_dir2_leaf_find_stale
Date: Mon, 11 Jul 2011 17:32:53 -0500 [thread overview]
Message-ID: <1310423573.7019.55.camel@doink> (raw)
In-Reply-To: <20110710205017.293539533@bombadil.infradead.org>
On Sun, 2011-07-10 at 16:49 -0400, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
OK, I guess this is fine. I have a suggestion below
but I see nothing truly wrong with what you have.
Reviewed-by: Alex Elder <aelder@sgi.com>
> Index: xfs/fs/xfs/xfs_dir2_leaf.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_dir2_leaf.c 2011-07-09 12:07:49.518499801 +0200
> +++ xfs/fs/xfs/xfs_dir2_leaf.c 2011-07-09 12:19:48.171796748 +0200
> @@ -148,6 +148,36 @@ xfs_dir2_block_to_leaf(
> return 0;
> }
>
> +STATIC void
> +xfs_dir2_leaf_find_stale(
> + struct xfs_dir2_leaf *leaf,
> + int index,
> + int *lowstale,
> + int *highstale)
> +{
> + /*
> + * Find the first stale entry before our index, if any.
> + */
> + for (*lowstale = index - 1;
> + *lowstale >= 0 &&
> + leaf->ents[*lowstale].address !=
> + cpu_to_be32(XFS_DIR2_NULL_DATAPTR);
> + --*lowstale)
> + continue;
> +
> + /*
> + * Find the first stale entry at or after our index, if any.
> + * Stop if the answer would be worse than lowstale.
Stop if the result would require moving more
entries than using lowstale.
(I realize you didn't change this comment, you just moved
it into this helper function.)
Actually it seems like this searching of the stale
entries and moving things around among them could
be broken into a few even finer-grained utility
routines. It just seems like what this code is
doing is simpler than what the code complexity
suggests (though I haven't really looked at this
stuff much before).
> + */
> + for (*highstale = index;
> + *highstale < be16_to_cpu(leaf->hdr.count) &&
> + leaf->ents[*highstale].address !=
> + cpu_to_be32(XFS_DIR2_NULL_DATAPTR) &&
> + (*lowstale < 0 || index - *lowstale > *highstale - index);
> + ++*highstale)
> + continue;
> +}
> +
> struct xfs_dir2_leaf_entry *
> xfs_dir2_leaf_find_entry(
> xfs_dir2_leaf_t *leaf, /* leaf structure */
. . .
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-07-11 22:32 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 20:49 [PATCH 00/11] a few more cleanups for Linux 3.1 Christoph Hellwig
2011-07-10 20:49 ` [PATCH 01/11] xfs: reshuffle dir2 headers Christoph Hellwig
2011-07-11 22:32 ` Alex Elder
2011-07-12 9:06 ` Christoph Hellwig
2011-07-10 20:49 ` [PATCH 02/11] xfs: cleanup struct xfs_dir2_free Christoph Hellwig
2011-07-11 22:32 ` Alex Elder
2011-07-10 20:49 ` [PATCH 03/11] xfs: factor out xfs_dir2_leaf_find_stale Christoph Hellwig
2011-07-11 22:32 ` Alex Elder [this message]
2011-07-12 9:09 ` Christoph Hellwig
2011-07-13 6:49 ` Dave Chinner
2011-07-13 7:16 ` Christoph Hellwig
2011-07-13 10:28 ` Dave Chinner
2011-07-10 20:49 ` [PATCH 04/11] xfs: factor out xfs_da_grow_inode_int Christoph Hellwig
2011-07-11 0:37 ` Dave Chinner
2011-07-11 5:24 ` Christoph Hellwig
2011-07-12 0:55 ` Dave Chinner
2011-07-11 22:32 ` Alex Elder
2011-07-10 20:49 ` [PATCH 05/11] xfs: add a proper transaction pointer to struct xfs_buf Christoph Hellwig
2011-07-11 22:33 ` Alex Elder
2011-07-12 9:12 ` Christoph Hellwig
2011-07-10 20:49 ` [PATCH 06/11] xfs: remove wrappers around b_fspriv Christoph Hellwig
2011-07-11 22:33 ` Alex Elder
2011-07-12 1:02 ` Dave Chinner
2011-07-12 9:15 ` Christoph Hellwig
2011-07-10 20:49 ` [PATCH 07/11] xfs: remove wrappers around b_iodone Christoph Hellwig
2011-07-11 22:33 ` Alex Elder
2011-07-10 20:49 ` [PATCH 08/11] xfs: remove the unused xfs_buf_delwri_sort function Christoph Hellwig
2011-07-11 22:33 ` Alex Elder
2011-07-10 20:49 ` [PATCH 09/11] xfs: remove the dead QUOTADEBUG debug Christoph Hellwig
2011-07-11 22:33 ` Alex Elder
2011-07-12 0:59 ` Dave Chinner
2011-07-10 20:49 ` [PATCH 10/11] xfs: remove leftovers of the old btree tracing code Christoph Hellwig
2011-07-12 2:52 ` Alex Elder
2011-07-10 20:49 ` [PATCH 11/11] xfs: kill the dead XFS_DABUF debug code Christoph Hellwig
2011-07-11 22:33 ` Alex Elder
2011-07-13 6:51 ` [PATCH 00/11] a few more cleanups for Linux 3.1 Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310423573.7019.55.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox