From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: start periodic workers later
Date: Mon, 11 Jul 2011 17:34:35 -0500 [thread overview]
Message-ID: <1310423675.7019.64.camel@doink> (raw)
In-Reply-To: <20110711135957.GA23737@infradead.org>
On Mon, 2011-07-11 at 09:59 -0400, Christoph Hellwig wrote:
> Start the periodic sync workers only after we have finished xfs_mountfs
> and thus fully set up the filesystem structures. Without this we can
> call into xfs_qm_sync before the quotainfo strucute is set up if the
> mount takes unusually long, and probably hit other incomplete states
> as well.
>
> Also clean up the xfs_fs_fill_super error path by using consistent
> label names, and removing an impossible to reach case.
>
> Reported-by: Arkadiusz Miskiewicz <arekm@maven.pl>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-07-11 22:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 13:59 [PATCH] xfs: start periodic workers later Christoph Hellwig
2011-07-11 22:34 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310423675.7019.64.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox