From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p6JN3tSc197822 for ; Tue, 19 Jul 2011 18:03:55 -0500 Subject: Re: [PATCH 2/4] xfs: remove confusing ail cursor wrapper From: Alex Elder In-Reply-To: <1310960419-9875-3-git-send-email-david@fromorbit.com> References: <1310960419-9875-1-git-send-email-david@fromorbit.com> <1310960419-9875-3-git-send-email-david@fromorbit.com> Date: Tue, 19 Jul 2011 18:03:50 -0500 Message-ID: <1311116630.1964.39.camel@doink> MIME-Version: 1.0 Reply-To: aelder@sgi.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Mon, 2011-07-18 at 13:40 +1000, Dave Chinner wrote: > From: Dave Chinner > > xfs_trans_ail_cursor_set() doesn't set the cursor to the current log > item, it sets it to the next item. There is already a function for > doing this - xfs_trans_ail_cursor_next() - and the _set function is > simply a two line wrapper. Remove it and open code the setting of > the cursor in the two locations that call it to remove the > confusion. > > Signed-off-by: Dave Chinner > Reviewed-by: Christoph Hellwig I already reviewed this but I do see you did a tiny change or two. In any case, this (still) looks good. Reviewed-by: Alex Elder _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs