public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/4] xfs: use a cursor for bulk AIL insertion
Date: Wed, 20 Jul 2011 10:16:01 -0500	[thread overview]
Message-ID: <1311174961.2906.6.camel@doink> (raw)
In-Reply-To: <20110719233644.GB9359@dastard>

On Wed, 2011-07-20 at 09:36 +1000, Dave Chinner wrote:
> On Tue, Jul 19, 2011 at 06:03:44PM -0500, Alex Elder wrote:
> > On Mon, 2011-07-18 at 13:40 +1000, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > > 
> > > Delayed logging can insert tens of thousands of log items into the
> > > AIL at the same LSN. When the committing of log commit records
> > > occur, we can get insertions occurring at a
. . .
> _after_ which the new
> >          * items should go.  If lip is null the AIL was empty, so
> >          * the new items go at the head of the AIL.
> >          */
> >         if (lip)
> >                 list_splice(list, &lip->li_ail);
> >         else
> >                 list_splice(list, &ailp->xa_ail);
> > }
> 
> 
> Looks cleaner, but I'll need to test it. Right now all my test
> resources are busy with non-mainline stuff, so it's going to be next
> week sometime before I can do this.

I'll actually try to test this today.	-Alex

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2011-07-20 15:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1310960419-9875-1-git-send-email-david@fromorbit.com>
2011-07-18  3:40 ` [PATCH 1/4] xfs: use a cursor for bulk AIL insertion Dave Chinner
2011-07-19  2:01   ` Christoph Hellwig
2011-07-19  3:12     ` Dave Chinner
2011-07-19 23:03   ` Alex Elder
2011-07-19 23:36     ` Dave Chinner
2011-07-20  0:15       ` Christoph Hellwig
2011-07-20  0:21         ` Dave Chinner
2011-07-20 15:13         ` Alex Elder
2011-07-20 15:16       ` Alex Elder [this message]
2011-07-18  3:40 ` [PATCH 2/4] xfs: remove confusing ail cursor wrapper Dave Chinner
2011-07-19 23:03   ` Alex Elder
2011-07-18  3:40 ` [PATCH 3/4] xfs: convert AIL cursors to use struct list_head Dave Chinner
2011-07-19 23:03   ` Alex Elder
2011-07-19 23:43     ` Dave Chinner
2011-07-20 15:19       ` Alex Elder
2011-07-18  3:40 ` [PATCH 4/4] xfs: add size update tracepoint to IO completion Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311174961.2906.6.camel@doink \
    --to=aelder@sgi.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox