From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/4] xfs: convert AIL cursors to use struct list_head
Date: Wed, 20 Jul 2011 10:19:35 -0500 [thread overview]
Message-ID: <1311175175.2906.8.camel@doink> (raw)
In-Reply-To: <20110719234324.GC9359@dastard>
On Wed, 2011-07-20 at 09:43 +1000, Dave Chinner wrote:
> On Tue, Jul 19, 2011 at 06:03:56PM -0500, Alex Elder wrote:
> > On Mon, 2011-07-18 at 13:40 +1000, Dave Chinne
. . .
> > > + * Get the next item in the traversal and advance the cursor. If the cursor
> > > + * was invalidated (indicated by a lip of 1), restart the traversal.
> > * was invalidated (indicated by its item pointer's low bit being set),
> > * restart the traversal.
>
> I thought I fixed that. Hmmmm, I did fix a comment that said the
> same thing - just it wasn't the one you noticed. :/ I'll fix it up
> when I redo the splice code again.
Don't worry about it. I'll change it (as I did here)
in my own copy and will use that (unless you give me
something newer before I'm ready to publish it).
You are welcome to update it later, of course.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-07-20 15:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1310960419-9875-1-git-send-email-david@fromorbit.com>
2011-07-18 3:40 ` [PATCH 1/4] xfs: use a cursor for bulk AIL insertion Dave Chinner
2011-07-19 2:01 ` Christoph Hellwig
2011-07-19 3:12 ` Dave Chinner
2011-07-19 23:03 ` Alex Elder
2011-07-19 23:36 ` Dave Chinner
2011-07-20 0:15 ` Christoph Hellwig
2011-07-20 0:21 ` Dave Chinner
2011-07-20 15:13 ` Alex Elder
2011-07-20 15:16 ` Alex Elder
2011-07-18 3:40 ` [PATCH 2/4] xfs: remove confusing ail cursor wrapper Dave Chinner
2011-07-19 23:03 ` Alex Elder
2011-07-18 3:40 ` [PATCH 3/4] xfs: convert AIL cursors to use struct list_head Dave Chinner
2011-07-19 23:03 ` Alex Elder
2011-07-19 23:43 ` Dave Chinner
2011-07-20 15:19 ` Alex Elder [this message]
2011-07-18 3:40 ` [PATCH 4/4] xfs: add size update tracepoint to IO completion Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311175175.2906.8.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox