From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix modulo-by-zero error in fsx
Date: Wed, 20 Jul 2011 18:04:15 -0500 [thread overview]
Message-ID: <1311203055.2906.75.camel@doink> (raw)
In-Reply-To: <1311047353-23925-1-git-send-email-david@fromorbit.com>
On Tue, 2011-07-19 at 13:49 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The recent fsx fixes has a logic error in the offset trimming code.
> If a read is done when the file size is zero, then the logic error
> causes a offset % 0 opertaion to occur. This causes fsx to get a
> SIGFPE and die.
>
> This was not discovered during my testing because I was using a
> random seed that didn't trip this condition. Changing the seed to
> that which test 091 uses (the default of 1) causes such an operation
> to occur....
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
I realize you already committed this, but I'm finally
getting around to reviewing it.
I started composing this message, explaining how you
should have done something differently. But at this
point it'll be more constructive to just send a patch
against what you have already committed. So that will
be coming shortly...
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-07-20 23:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 3:49 [PATCH] xfstests: fix modulo-by-zero error in fsx Dave Chinner
2011-07-19 17:10 ` Christoph Hellwig
2011-07-20 23:04 ` Alex Elder [this message]
2011-07-20 23:13 ` Dave Chinner
2011-07-24 12:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311203055.2906.75.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox