public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 09/12] Replace the macro XFS_BUF_ISPINNED with helper xfs_buf_ispinned
Date: Fri, 22 Jul 2011 14:38:34 -0500	[thread overview]
Message-ID: <1311363514.2771.104.camel@doink> (raw)
In-Reply-To: <20110722003343.21069.95122.sendpatchset@chandra-lucid.beaverton.ibm.com>

On Thu, 2011-07-21 at 17:33 -0700, Chandra Seetharaman wrote:
> Replace the macro XFS_BUF_ISPINNED with an inline helper function
> xfs_buf_ispinned, and change all its usages.
> 
> Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

One simple suggestion below.  Otherwise:

Reviewed-by: Alex Elder <aelder@sgi.com>

> diff --git a/fs/xfs/linux-2.6/xfs_buf.h b/fs/xfs/linux-2.6/xfs_buf.h
> index 7b1f484..71e1d6f 100644
> --- a/fs/xfs/linux-2.6/xfs_buf.h
> +++ b/fs/xfs/linux-2.6/xfs_buf.h
> @@ -280,7 +280,10 @@ xfs_buf_set_ref(
>  #define XFS_BUF_SET_VTYPE_REF(bp, type, ref)	xfs_buf_set_ref(bp, ref)
>  #define XFS_BUF_SET_VTYPE(bp, type)		do { } while (0)
>  
> -#define XFS_BUF_ISPINNED(bp)	atomic_read(&((bp)->b_pin_count))
> +static inline int xfs_buf_ispinned(struct xfs_buf *bp)
> +{
> +	return atomic_read(&(bp->b_pin_count));

Good idea.  But drop the extra parentheses:

	return atomic_read(&bp->b_pin_count);

> +}
>  
>  #define XFS_BUF_FINISH_IOWAIT(bp)	complete(&bp->b_iowait);
>  


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-07-22 19:38 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22  0:32 [PATCH 00/12] Remove number of macros from xfs_buf.h Chandra Seetharaman
2011-07-22  0:32 ` [PATCH 01/12] xfs: Remove the macro XFS_BUF_BFLAGS Chandra Seetharaman
2011-07-22 19:37   ` Alex Elder
2011-07-22  0:32 ` [PATCH 02/12] xfs: Remove the macro XFS_BUF_ZEROFLAGS Chandra Seetharaman
2011-07-22  0:32 ` [PATCH 03/12] xfs: Remove the macro XFS_BUF_ERROR and family Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22 20:49     ` Chandra Seetharaman
2011-07-22 21:10       ` Alex Elder
2011-07-22 21:30         ` Alex Elder
2011-07-22 21:31         ` Chandra Seetharaman
2011-07-22  0:33 ` [PATCH 04/12] xfs: Remove macro XFS_BUF_BUSY " Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:33 ` [PATCH 05/12] xfs: Remove macro XFS_BUF_HOLD Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:33 ` [PATCH 06/12] xfs: Remove macro XFS_BUF_SET_START Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:33 ` [PATCH 07/12] xfs: Remove the macro XFS_BUF_PTR Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:33 ` [PATCH 08/12] xfs: Remove the macro XFS_BUF_SET_PTR Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22 20:50     ` Chandra Seetharaman
2011-07-24 11:35     ` Christoph Hellwig
2011-07-25 15:57       ` Alex Elder
2011-07-25 16:25         ` Christoph Hellwig
2011-07-25 16:58           ` Alex Elder
2011-07-25 22:18         ` Chandra Seetharaman
2011-07-22  0:33 ` [PATCH 09/12] Replace the macro XFS_BUF_ISPINNED with helper xfs_buf_ispinned Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder [this message]
2011-07-22 20:51     ` Chandra Seetharaman
2011-07-22  0:33 ` [PATCH 10/12] xfs: Remove the macro XFS_BUF_SET_TARGET Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:34 ` [PATCH 11/12] xfs: Remove the macro XFS_BUF_TARGET Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22 19:46   ` Alex Elder
2011-07-22  0:34 ` [PATCH 12/12] xfs: Remove the macro XFS_BUFTARG_NAME Chandra Seetharaman
2011-07-22 19:49   ` Alex Elder
2011-07-22 21:23     ` Chandra Seetharaman
2011-07-22 21:26       ` Chandra Seetharaman
2011-07-24 11:37     ` Christoph Hellwig
2011-07-25 15:57       ` Alex Elder
2011-07-25 16:26         ` Christoph Hellwig
2011-07-25 22:18         ` Chandra Seetharaman
  -- strict thread matches above, loose matches on Subject: below --
2011-07-16  1:21 [PATCH 00/12] Remove number of macros from xfs_buf.h Chandra Seetharaman
2011-07-16  1:21 ` [PATCH 09/12] Replace the macro XFS_BUF_ISPINNED with helper xfs_buf_ispinned Chandra Seetharaman
2011-07-16  2:05   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311363514.2771.104.camel@doink \
    --to=aelder@sgi.com \
    --cc=sekharan@us.ibm.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox