From: Alex Elder <aelder@sgi.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v3] xfs_repair: Check if agno is inside the filesystem
Date: Mon, 25 Jul 2011 09:45:47 -0500 [thread overview]
Message-ID: <1311605147.2914.10.camel@doink> (raw)
In-Reply-To: <alpine.LFD.2.00.1107251604580.9742@dhcp-27-109.brq.redhat.com>
On Mon, 2011-07-25 at 16:06 +0200, Lukas Czerner wrote:
> On Fri, 15 Jul 2011, Alex Elder wrote:
>
> > On Tue, 2011-06-28 at 16:26 +0200, Lukas Czerner wrote:
> > > When getting an inode tree pointer from an array inode_tree_ptrs, we
> > > should check if agno, which is used as a pointer to the array, lives
> > > within the file system, because if it is not, we can end up touching
> > > uninitialized memory. This may happen if we have corrupted directory
> > > entry.
> > >
> > > This commit fixes it by passing xfs_mount to affected functions and
> > > checking if agno really is inside the file system.
> > >
> > > This solves Red Hat bug #694706
> > >
> > > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> >
> > OK, it looks like there are basically four changes
> > here--adding the mount point argument to four functions
> > and using it to verify (or assert the validity of) the
> > an AG number. The rest of the changes are simply the
> > rippling-back effect of adding the mount point.
> >
> > The change looks good to me. If nobody else objects to
> > the change I will commit this for you.
> >
> > Reviewed-by: Alex Elder <aelder@sgi.com>
>
> Thanks Alex!
>
> I still can not see it in the git though, so what is the status of this
> patch ?
Sorry about that, I missed this one when I committed some
things last week. I'll get it in this week, likely today.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-07-25 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 14:26 [PATCH v3] xfs_repair: Check if agno is inside the filesystem Lukas Czerner
2011-07-15 15:07 ` Alex Elder
2011-07-25 14:06 ` Lukas Czerner
2011-07-25 14:45 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311605147.2914.10.camel@doink \
--to=aelder@sgi.com \
--cc=lczerner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox