From: Alex Elder <aelder@sgi.com>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS
Date: Mon, 25 Jul 2011 09:51:40 -0500 [thread overview]
Message-ID: <1311605500.2914.12.camel@doink> (raw)
In-Reply-To: <20110722233945.14612.1955.sendpatchset@chandra-lucid.beaverton.ibm.com>
On Fri, 2011-07-22 at 16:39 -0700, Chandra Seetharaman wrote:
> Remove the definition and usage of the macro XFS_BUF_ZEROFLAGS.
>
> In the specific contexts, not all flags need to be cleared. Hence the
> simplification.
>
> Rationale for xfs_log.c:
> from hch: XBF_READ and XBF_DELWRI will never be set here, XBF_WRITE
> XBF_ASYNC, and XBF_SYNCIO are set just below.
> Hence clearing only XBF_FUA and XBF_FLUSH would suffice.
>
> Rationale for xfs_log_recover.c
> from hch: XBF_READ, XBF_WRITE, XBF_ASYNC and XBF_DELWRI already get dealt with
> in xfs_bwrite a few lines down.
> from hch: XBF_SYNCIO, XBF_FUA and XBF_FLUSH are used only in log buffers. No
> need to clear them here.
Sorry, I reviewed this last week and signed off on it
but I see it's stuck in my mail outbox for some reason.
Reviewed-by: Alex Elder <aelder@sgi.com>
> Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
> ---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-07-25 14:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 23:39 [PATCH 00/12 v3] Remove number of macros from xfs_buf.h Chandra Seetharaman
2011-07-22 23:39 ` [PATCH 01/12 v3] xfs: Remove the macro XFS_BUF_BFLAGS Chandra Seetharaman
2011-07-22 23:39 ` [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS Chandra Seetharaman
2011-07-24 11:39 ` Christoph Hellwig
2011-07-25 15:57 ` Alex Elder
2011-07-25 16:27 ` Christoph Hellwig
2011-07-25 17:07 ` Alex Elder
2011-07-25 17:09 ` Christoph Hellwig
2011-07-25 22:21 ` Chandra Seetharaman
2011-07-25 14:51 ` Alex Elder [this message]
2011-07-22 23:39 ` [PATCH 03/12 v3] xfs: Remove the macro XFS_BUF_ERROR and family Chandra Seetharaman
2011-07-24 11:40 ` Christoph Hellwig
2011-07-22 23:39 ` [PATCH 04/12 v3] xfs: Remove macro XFS_BUF_BUSY " Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 05/12 v3] xfs: Remove macro XFS_BUF_HOLD Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 06/12 v3] xfs: Remove macro XFS_BUF_SET_START Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 07/12 v3] xfs: Remove the macro XFS_BUF_PTR Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 08/12 v3] xfs: Remove the macro XFS_BUF_SET_PTR Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 09/12 v3] Replace the macro XFS_BUF_ISPINNED with helper xfs_buf_ispinned Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 10/12 v3] xfs: Remove the macro XFS_BUF_SET_TARGET Chandra Seetharaman
2011-07-24 11:41 ` Christoph Hellwig
2011-07-22 23:40 ` [PATCH 11/12 v3] xfs: Remove the macro XFS_BUF_TARGET Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 12/12 v3] xfs: Remove the macro XFS_BUFTARG_NAME Chandra Seetharaman
2011-07-25 17:36 ` [PATCH 00/12 v3] Remove number of macros from xfs_buf.h Alex Elder
2011-07-25 20:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311605500.2914.12.camel@doink \
--to=aelder@sgi.com \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox