From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Chandra Seetharaman <sekharan@us.ibm.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS
Date: Mon, 25 Jul 2011 10:57:32 -0500 [thread overview]
Message-ID: <1311609452.2914.23.camel@doink> (raw)
In-Reply-To: <20110724113959.GD26332@infradead.org>
On Sun, 2011-07-24 at 07:39 -0400, Christoph Hellwig wrote:
> > @@ -1247,6 +1247,7 @@ xlog_bdstrat(
> > {
> > struct xlog_in_core *iclog = bp->b_fspriv;
> >
> > + bp->b_flags &= ~(XBF_FUA|XBF_FLUSH);
>
> I don't think this is correct, we set these before calling into
> xlog_bdstrat, so this means we'll always stip it off after that.
>
> Given that this area is more complicated than the pure macro removal
> how about letting it as-is for now? I have some bigger refactoring
> in this area in my queue, and I'll just incorporate the
> XFS_BUF_ZEROFLAGS into it.
Christoph, are you suggesting that this one hunk just
be excluded from the series? Or the entire patch?
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-07-25 15:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 23:39 [PATCH 00/12 v3] Remove number of macros from xfs_buf.h Chandra Seetharaman
2011-07-22 23:39 ` [PATCH 01/12 v3] xfs: Remove the macro XFS_BUF_BFLAGS Chandra Seetharaman
2011-07-22 23:39 ` [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS Chandra Seetharaman
2011-07-24 11:39 ` Christoph Hellwig
2011-07-25 15:57 ` Alex Elder [this message]
2011-07-25 16:27 ` Christoph Hellwig
2011-07-25 17:07 ` Alex Elder
2011-07-25 17:09 ` Christoph Hellwig
2011-07-25 22:21 ` Chandra Seetharaman
2011-07-25 14:51 ` Alex Elder
2011-07-22 23:39 ` [PATCH 03/12 v3] xfs: Remove the macro XFS_BUF_ERROR and family Chandra Seetharaman
2011-07-24 11:40 ` Christoph Hellwig
2011-07-22 23:39 ` [PATCH 04/12 v3] xfs: Remove macro XFS_BUF_BUSY " Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 05/12 v3] xfs: Remove macro XFS_BUF_HOLD Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 06/12 v3] xfs: Remove macro XFS_BUF_SET_START Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 07/12 v3] xfs: Remove the macro XFS_BUF_PTR Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 08/12 v3] xfs: Remove the macro XFS_BUF_SET_PTR Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 09/12 v3] Replace the macro XFS_BUF_ISPINNED with helper xfs_buf_ispinned Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 10/12 v3] xfs: Remove the macro XFS_BUF_SET_TARGET Chandra Seetharaman
2011-07-24 11:41 ` Christoph Hellwig
2011-07-22 23:40 ` [PATCH 11/12 v3] xfs: Remove the macro XFS_BUF_TARGET Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 12/12 v3] xfs: Remove the macro XFS_BUFTARG_NAME Chandra Seetharaman
2011-07-25 17:36 ` [PATCH 00/12 v3] Remove number of macros from xfs_buf.h Alex Elder
2011-07-25 20:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311609452.2914.23.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox