From: Alex Elder <aelder@sgi.com>
To: Bill Kendall <wkendall@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsdump: allow multi-digit dialog prompts
Date: Tue, 9 Aug 2011 15:55:05 -0500 [thread overview]
Message-ID: <1312923305.9482.0.camel@doink> (raw)
In-Reply-To: <1311784913-14191-1-git-send-email-wkendall@sgi.com>
On Wed, 2011-07-27 at 11:41 -0500, Bill Kendall wrote:
> xfsdump issues a multiple-choice dialog in various circumstances
> (e.g., media change request). An assert incorrectly limits this to
> at most 8 choices even though the code can handle up to 9. Remove
> the assert and change the code to handle multi-digit responses.
>
> Signed-off-by: Bill Kendall <wkendall@sgi.com>
Sorry I didn't get to this sooner.
I had a few minor quibbles, but I'm not going to even bother
mentioning them. Your change looks good. I'll commit this
for you.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-08-09 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 16:41 [PATCH] xfsdump: allow multi-digit dialog prompts Bill Kendall
2011-08-02 9:55 ` Christoph Hellwig
2011-08-09 20:55 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312923305.9482.0.camel@doink \
--to=aelder@sgi.com \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox