From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p81JMA5a035116 for ; Thu, 1 Sep 2011 14:22:10 -0500 Subject: Re: [PATCH 03/11] xfs: move more delwri setup into xfs_buf_delwri_queue From: Alex Elder In-Reply-To: <20110823082912.320240070@bombadil.infradead.org> References: <20110823082802.335389799@bombadil.infradead.org> <20110823082912.320240070@bombadil.infradead.org> Date: Thu, 1 Sep 2011 14:22:09 -0500 Message-ID: <1314904929.2903.61.camel@doink> MIME-Version: 1.0 Reply-To: aelder@sgi.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Tue, 2011-08-23 at 04:28 -0400, Christoph Hellwig wrote: > Do not transfer a reference held by the caller to the buffer on the list, > or decrement it in xfs_buf_delwri_queue, but instead grab a new reference > if needed, and let the caller drop its own reference. Also move setting > of the XBF_DELWRI and XBF_ASYNC flags into xfs_buf_delwri_queue, and > only do it if needed. Note that for now xfs_buf_unlock already has > XBF_DELWRI, but that will change in the following patches. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Dave Chinner Definite improvement. Reviewed-by: Alex Elder _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs