From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: improve ioend error handling
Date: Mon, 12 Sep 2011 09:40:35 -0500 [thread overview]
Message-ID: <1315838435.2916.41.camel@doink> (raw)
In-Reply-To: <20110824060149.777198300@bombadil.infradead.org>
On Wed, 2011-08-24 at 01:59 -0400, Christoph Hellwig wrote:
> Return unwritten extent conversion errors to aio_complete.
It might have been good to call attention to the fact that
you were fixing it so ioend->io_error is consistently a
negative errno value now, thereby making the above change
possible.
Are we going to drop the last argument to aio_complete() now?
Anyway, this looks good, and as you privately requested
I will commit this patch without waiting for resolution
of issues in the other two in this series.
> Skip both unwritten extent conversion and size updates if we had an I/O error
> or the filesystem has been shut down.
>
> Return -EIO to the aio/buffer completion handlers in case of a forced shutdown.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-12 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 5:59 [PATCH 0/3] RFC: log all i_size updates Christoph Hellwig
2011-08-24 5:59 ` [PATCH 1/3] xfs: improve ioend error handling Christoph Hellwig
2011-09-02 0:19 ` Dave Chinner
2011-09-12 14:40 ` Alex Elder [this message]
2011-09-12 14:49 ` Christoph Hellwig
2011-08-24 5:59 ` [PATCH 2/3] xfs: use per-filesystem I/O completion workqueues Christoph Hellwig
2011-08-25 0:48 ` Dave Chinner
2011-08-25 5:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315838435.2916.41.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox